Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2339223003:
Remove QUIC's Interval::difference. (Closed)
|
Created:
4 years, 3 months ago by Avi (use Gerrit) Modified:
4 years, 3 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove QUIC's Interval::difference(vector<Interval*>*).
It's unused.
BUG=555865
R=bnc@chromium.org
Committed: https://crrev.com/04d50002836c9cc18d131e450d1db50d5cf67cd5
Cr-Commit-Position: refs/heads/master@{#418890}
Patch Set 1 #Patch Set 2 : delete instead #
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
... or should I delete the code since no one uses it?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bnc@chromium.org changed reviewers: + rch@chromium.org
On 2016/09/14 21:25:50, Avi wrote: > ... or should I delete the code since no one uses it? LGTM for the unique_ptr change. Looping in rch@ for whether this method should be deleted.
On 2016/09/15 12:24:52, Bence wrote: > On 2016/09/14 21:25:50, Avi wrote: > > ... or should I delete the code since no one uses it? > > LGTM for the unique_ptr change. > > Looping in rch@ for whether this method should be deleted. Looks like both of these should be deleted!
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use unique_ptr for QUIC's Interval::difference. BUG=555865 R=bnc@chromium.org ========== to ========== Remove QUIC's Interval::difference(vector<Interval*>). It's unused. BUG=555865 R=bnc@chromium.org ==========
Description was changed from ========== Remove QUIC's Interval::difference(vector<Interval*>). It's unused. BUG=555865 R=bnc@chromium.org ========== to ========== Remove QUIC's Interval::difference(vector<Interval*>*). It's unused. BUG=555865 R=bnc@chromium.org ==========
Take a look again, then.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rch@chromium.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org Link to the patchset: https://codereview.chromium.org/2339223003/#ps20001 (title: "delete instead")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove QUIC's Interval::difference(vector<Interval*>*). It's unused. BUG=555865 R=bnc@chromium.org ========== to ========== Remove QUIC's Interval::difference(vector<Interval*>*). It's unused. BUG=555865 R=bnc@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove QUIC's Interval::difference(vector<Interval*>*). It's unused. BUG=555865 R=bnc@chromium.org ========== to ========== Remove QUIC's Interval::difference(vector<Interval*>*). It's unused. BUG=555865 R=bnc@chromium.org Committed: https://crrev.com/04d50002836c9cc18d131e450d1db50d5cf67cd5 Cr-Commit-Position: refs/heads/master@{#418890} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/04d50002836c9cc18d131e450d1db50d5cf67cd5 Cr-Commit-Position: refs/heads/master@{#418890} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
