Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1756)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Rebase & Conflict Resolution Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
index f4bf2e463ee5dd9a878b36303e11f53477cff45e..5b0f50e6c2293b8d0e85e7ddb69717442ccff43f 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
@@ -82,8 +82,9 @@ public class RequestFinishedInfoTest extends CronetTestBase {
TestRequestFinishedListener requestFinishedListener = new TestRequestFinishedListener();
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ ExperimentalUrlRequest.Builder urlRequestBuilder =
+ (ExperimentalUrlRequest.Builder) mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
Date startTime = new Date();
urlRequestBuilder.addRequestAnnotation("request annotation")
.addRequestAnnotation(this)
@@ -113,8 +114,9 @@ public class RequestFinishedInfoTest extends CronetTestBase {
new TestRequestFinishedListener(testExecutor);
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ ExperimentalUrlRequest.Builder urlRequestBuilder =
+ (ExperimentalUrlRequest.Builder) mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
Date startTime = new Date();
urlRequestBuilder.addRequestAnnotation("request annotation")
.addRequestAnnotation(this)
@@ -146,8 +148,9 @@ public class RequestFinishedInfoTest extends CronetTestBase {
mTestFramework.mCronetEngine.addRequestFinishedListener(firstListener);
mTestFramework.mCronetEngine.addRequestFinishedListener(secondListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ ExperimentalUrlRequest.Builder urlRequestBuilder =
+ (ExperimentalUrlRequest.Builder) mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
Date startTime = new Date();
urlRequestBuilder.addRequestAnnotation("request annotation")
.addRequestAnnotation(this)
@@ -188,8 +191,8 @@ public class RequestFinishedInfoTest extends CronetTestBase {
TestRequestFinishedListener requestFinishedListener = new TestRequestFinishedListener();
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(connectionRefusedUrl,
- callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest.Builder urlRequestBuilder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ connectionRefusedUrl, callback, callback.getExecutor());
Date startTime = new Date();
urlRequestBuilder.build().start();
callback.blockForDone();
@@ -240,8 +243,8 @@ public class RequestFinishedInfoTest extends CronetTestBase {
new TestRequestFinishedListener(testExecutor);
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest.Builder urlRequestBuilder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
UrlRequest request = urlRequestBuilder.build();
mTestFramework.mCronetEngine.removeRequestFinishedListener(requestFinishedListener);
request.start();
@@ -267,8 +270,9 @@ public class RequestFinishedInfoTest extends CronetTestBase {
request.cancel();
}
};
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ ExperimentalUrlRequest.Builder urlRequestBuilder =
+ mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
Date startTime = new Date();
urlRequestBuilder.addRequestAnnotation("request annotation")
.addRequestAnnotation(this)

Powered by Google App Engine
This is Rietveld 408576698