Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Rebase & Conflict Resolution Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java
index d46c04ea3117b322b6b62efb804383e168e4cc94..5d7bdfe0a95a22d446b1268f0edb297faa672a4a 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java
@@ -50,15 +50,16 @@ public class DiskStorageTest extends CronetTestBase {
assertTrue(readOnlyStorage.mkdir());
// Setting the storage directory as readonly has no effect.
assertTrue(readOnlyStorage.setReadOnly());
- CronetEngine.Builder builder = new CronetEngine.Builder(getContext());
+ ExperimentalCronetEngine.Builder builder =
+ new ExperimentalCronetEngine.Builder(getContext());
builder.setStoragePath(mReadOnlyStoragePath);
builder.enableHttpCache(CronetEngine.Builder.HTTP_CACHE_DISK, 1024 * 1024);
mTestFramework = new CronetTestFramework(null, null, getContext(), builder);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
String url = NativeTestServer.getFileURL("/cacheable.txt");
- UrlRequest.Builder requestBuilder = new UrlRequest.Builder(
- url, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest.Builder requestBuilder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ url, callback, callback.getExecutor());
UrlRequest urlRequest = requestBuilder.build();
urlRequest.start();
callback.blockForDone();
@@ -112,15 +113,16 @@ public class DiskStorageTest extends CronetTestBase {
}
}
- CronetEngine.Builder builder = new CronetEngine.Builder(getContext());
+ ExperimentalCronetEngine.Builder builder =
+ new ExperimentalCronetEngine.Builder(getContext());
builder.setStoragePath(CronetTestFramework.getTestStorage(getContext()));
builder.enableHttpCache(CronetEngine.Builder.HTTP_CACHE_DISK, 1024 * 1024);
mTestFramework = new CronetTestFramework(null, null, getContext(), builder);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
String url = NativeTestServer.getFileURL("/cacheable.txt");
- UrlRequest.Builder requestBuilder = new UrlRequest.Builder(
- url, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest.Builder requestBuilder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ url, callback, callback.getExecutor());
UrlRequest urlRequest = requestBuilder.build();
urlRequest.start();
callback.blockForDone();
@@ -152,15 +154,16 @@ public class DiskStorageTest extends CronetTestBase {
// Tests that if cache version is current, Cronet does not purge the directory.
public void testCacheVersionCurrent() throws Exception {
// Initialize a CronetEngine and shut it down.
- CronetEngine.Builder builder = new CronetEngine.Builder(getContext());
+ ExperimentalCronetEngine.Builder builder =
+ new ExperimentalCronetEngine.Builder(getContext());
builder.setStoragePath(CronetTestFramework.getTestStorage(getContext()));
builder.enableHttpCache(CronetEngine.Builder.HTTP_CACHE_DISK, 1024 * 1024);
mTestFramework = new CronetTestFramework(null, null, getContext(), builder);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
String url = NativeTestServer.getFileURL("/cacheable.txt");
- UrlRequest.Builder requestBuilder = new UrlRequest.Builder(
- url, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest.Builder requestBuilder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ url, callback, callback.getExecutor());
UrlRequest urlRequest = requestBuilder.build();
urlRequest.start();
callback.blockForDone();
@@ -186,7 +189,7 @@ public class DiskStorageTest extends CronetTestBase {
TestUrlRequestCallback callback2 = new TestUrlRequestCallback();
String url2 = NativeTestServer.getFileURL("/cacheable.txt");
UrlRequest.Builder requestBuilder2 =
- new UrlRequest.Builder(url2, callback2, callback2.getExecutor(), engine);
+ engine.newUrlRequestBuilder(url2, callback2, callback2.getExecutor());
UrlRequest urlRequest2 = requestBuilder2.build();
urlRequest2.start();
callback2.blockForDone();

Powered by Google App Engine
This is Rietveld 408576698