components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java - Issue 2339223002: Cronet API Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

Issue 2339223002: Cronet API Refactoring (Closed)

Patch Set: Rebase & Conflict Resolution Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/sample/AndroidManifest.xml ('k') | components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

diff --git a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

index 7dc79d391bab301c0c93c7a0e571fec9e3c40b50..3512b9c94e822559d0eb44d5dc20cf80dfb53b09 100644

--- a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

+++ b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

@@ -5,9 +5,9 @@

package org.chromium.cronet_sample_apk;

import android.app.Activity;

-import android.app.AlertDialog;

import android.content.DialogInterface;

import android.os.Bundle;

+import android.support.v7.app.AlertDialog;

import android.view.LayoutInflater;

import android.view.View;

import android.widget.EditText;

@@ -169,7 +169,7 @@ public class CronetSampleActivity extends Activity {

Executor executor = Executors.newSingleThreadExecutor();

UrlRequest.Callback callback = new SimpleUrlRequestCallback();

- UrlRequest.Builder builder = new UrlRequest.Builder(url, callback, executor, mCronetEngine);

+ UrlRequest.Builder builder = mCronetEngine.newUrlRequestBuilder(url, callback, executor);

applyPostDataToUrlRequestBuilder(builder, executor, postData);

builder.build().start();

}