Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: components/cronet/android/api/src/org/chromium/net/UploadDataSink.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Rebase & Conflict Resolution Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/UploadDataSink.java
diff --git a/components/cronet/android/api/src/org/chromium/net/UploadDataSink.java b/components/cronet/android/api/src/org/chromium/net/UploadDataSink.java
index 213ccefe74623f9b0aa3c082854fcf0252ff82d2..5474559635fbab71956a5bcdb353976bdf00dcfa 100644
--- a/components/cronet/android/api/src/org/chromium/net/UploadDataSink.java
+++ b/components/cronet/android/api/src/org/chromium/net/UploadDataSink.java
@@ -5,32 +5,32 @@
package org.chromium.net;
/**
- * Interface with callbacks methods for {@link UploadDataProvider}. All methods
+ * Defines callbacks methods for {@link UploadDataProvider}. All methods
* may be called synchronously or asynchronously, on any thread.
*/
-public interface UploadDataSink {
+public abstract class UploadDataSink {
/**
* Called by {@link UploadDataProvider} when a read succeeds.
* @param finalChunk For chunked uploads, {@code true} if this is the final
* read. It must be {@code false} for non-chunked uploads.
*/
- public void onReadSucceeded(boolean finalChunk);
+ public abstract void onReadSucceeded(boolean finalChunk);
/**
* Called by {@link UploadDataProvider} when a read fails.
* @param exception Exception passed on to the embedder.
*/
- public void onReadError(Exception exception);
+ public abstract void onReadError(Exception exception);
/**
* Called by {@link UploadDataProvider} when a rewind succeeds.
*/
- public void onRewindSucceeded();
+ public abstract void onRewindSucceeded();
/**
* Called by {@link UploadDataProvider} when a rewind fails, or if rewinding
* uploads is not supported.
* @param exception Exception passed on to the embedder.
*/
- public void onRewindError(Exception exception);
+ public abstract void onRewindError(Exception exception);
}

Powered by Google App Engine
This is Rietveld 408576698