Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Javadoc + rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
index 9bc276b072817930360d6f0af2a405050b666416..8c5528fc084fbaa1b6ac3884ea740943ebea7325 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
@@ -107,8 +107,9 @@ public class RequestFinishedInfoTest extends CronetTestBase {
new TestRequestFinishedListener(testExecutor);
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ ExperimentalUrlRequest.Builder urlRequestBuilder =
+ (ExperimentalUrlRequest.Builder) mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
urlRequestBuilder.addRequestAnnotation("request annotation")
.addRequestAnnotation(this)
.build()
@@ -140,8 +141,9 @@ public class RequestFinishedInfoTest extends CronetTestBase {
new TestRequestFinishedListener(testExecutor);
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ ExperimentalUrlRequest.Builder urlRequestBuilder =
+ (ExperimentalUrlRequest.Builder) mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
urlRequestBuilder.addRequestAnnotation("request annotation")
.addRequestAnnotation(this)
.build()
@@ -173,8 +175,9 @@ public class RequestFinishedInfoTest extends CronetTestBase {
mTestFramework.mCronetEngine.addRequestFinishedListener(firstListener);
mTestFramework.mCronetEngine.addRequestFinishedListener(secondListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ ExperimentalUrlRequest.Builder urlRequestBuilder =
+ (ExperimentalUrlRequest.Builder) mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
urlRequestBuilder.addRequestAnnotation("request annotation")
.addRequestAnnotation(this)
.build()
@@ -218,8 +221,8 @@ public class RequestFinishedInfoTest extends CronetTestBase {
new TestRequestFinishedListener(testExecutor);
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(connectionRefusedUrl,
- callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest.Builder urlRequestBuilder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ connectionRefusedUrl, callback, callback.getExecutor());
urlRequestBuilder.build().start();
callback.blockForDone();
assertTrue(callback.mOnErrorCalled);
@@ -249,8 +252,8 @@ public class RequestFinishedInfoTest extends CronetTestBase {
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
mTestFramework.mCronetEngine.removeRequestFinishedListener(requestFinishedListener);
TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
- mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
+ UrlRequest.Builder urlRequestBuilder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+ mUrl, callback, callback.getExecutor());
urlRequestBuilder.build().start();
callback.blockForDone();
testExecutor.runAllTasks();

Powered by Google App Engine
This is Rietveld 408576698