Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Javadoc + rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
similarity index 84%
rename from components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
rename to components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
index fc906f593fb066aa102b57796c58027c80e67fe8..d18de394096ef29a73e1c54fea82facc4d978ae1 100644
--- a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
@@ -2,11 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.net;
+package org.chromium.net.impl;
import static android.os.Process.THREAD_PRIORITY_BACKGROUND;
import static android.os.Process.THREAD_PRIORITY_MORE_FAVORABLE;
+import org.chromium.net.ApiVersion;
+import org.chromium.net.BidirectionalStream;
+import org.chromium.net.EffectiveConnectionType;
+import org.chromium.net.NetworkQualityRttListener;
+import org.chromium.net.NetworkQualityThroughputListener;
+import org.chromium.net.RequestFinishedInfo;
+import org.chromium.net.UrlRequest;
+
import java.io.IOException;
import java.net.Proxy;
import java.net.URL;
@@ -26,7 +34,7 @@ import java.util.concurrent.ThreadFactory;
*
* <p>Does not support netlogs, transferred data measurement, bidistream, cache, or priority.
*/
-final class JavaCronetEngine extends CronetEngine {
+public final class JavaCronetEngine extends CronetEngineBase {
private final String mUserAgent;
private final ExecutorService mExecutorService =
@@ -51,12 +59,12 @@ final class JavaCronetEngine extends CronetEngine {
}
});
- JavaCronetEngine(String userAgent) {
+ public JavaCronetEngine(String userAgent) {
this.mUserAgent = userAgent;
}
@Override
- public UrlRequest createRequest(String url, UrlRequest.Callback callback, Executor executor,
+ public UrlRequestBase createRequest(String url, UrlRequest.Callback callback, Executor executor,
int priority, Collection<Object> connectionAnnotations, boolean disableCache,
boolean disableConnectionMigration, boolean allowDirectExecutor) {
return new JavaUrlRequest(
@@ -67,13 +75,21 @@ final class JavaCronetEngine extends CronetEngine {
public BidirectionalStream createBidirectionalStream(String url,
BidirectionalStream.Callback callback, Executor executor, String httpMethod,
List<Map.Entry<String, String>> requestHeaders,
- @BidirectionalStream.Builder.StreamPriority int priority,
+ @BidirectionalStreamBuilderImpl.StreamPriority int priority,
boolean delayRequestHeadersUntilFirstFlush) {
throw new UnsupportedOperationException(
"Can't create a bidi stream - httpurlconnection doesn't have those APIs");
}
@Override
+ public BidirectionalStream.Builder newBidirectionalStreamBuilder(
+ String url, BidirectionalStream.Callback callback, Executor executor) {
+ throw new UnsupportedOperationException(
+ "The bidirectional stream is not supported by the Java implementation "
+ + "of Cronet Engine");
+ }
+
+ @Override
public boolean isEnabled() {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698