Cronet API Refactoring

components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java

Index: components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java
diff --git a/components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java b/components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java
new file mode 100644
index 0000000000000000000000000000000000000000..231cb4da8a3d0077eb9de1415fa1755de1f93902
--- /dev/null
+++ b/components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java
@@ -0,0 +1,34 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+package org.chromium.net;
+
+import java.util.Date;
+import java.util.Set;
+
+/**
+ * Defines methods that the actual implementation of {@link CronetEngine.Builder} has to implement.
+ * {@code CronetEngine.Builder} uses this interface to delegate the calls.
+ */
+public interface ICronetEngineBuilder {

[pauljensen, 2016/09/20 19:01:37]

as discussed, all experimental methods might want to have default impls so we
don't have to support them forever

[kapishnikov, 2016/09/22 21:32:03]

That is a very good point. Changed it to an abstract class and added the default
implementation of the experimental method.

+    ICronetEngineBuilder addPublicKeyPins(String hostName, Set<byte[]> pinsSha256,
+            boolean includeSubdomains, Date expirationDate);
+    ICronetEngineBuilder addQuicHint(String host, int port, int alternatePort);
+    ICronetEngineBuilder enableDataReductionProxy(String key);
+    ICronetEngineBuilder enableHttp2(boolean value);
+    ICronetEngineBuilder enableHttpCache(int cacheMode, long maxSize);
+    ICronetEngineBuilder enableLegacyMode(boolean value);
+    ICronetEngineBuilder enableNetworkQualityEstimator(boolean value);
+    ICronetEngineBuilder enablePublicKeyPinningBypassForLocalTrustAnchors(boolean value);
+    ICronetEngineBuilder enableQuic(boolean value);
+    ICronetEngineBuilder enableSdch(boolean value);
+    ICronetEngineBuilder setCertVerifierData(String certVerifierData);
+    ICronetEngineBuilder setExperimentalOptions(String options);
+    ICronetEngineBuilder setLibraryLoader(CronetEngine.Builder.LibraryLoader loader);
+    ICronetEngineBuilder setDataReductionProxyOptions(
+            String primaryProxy, String fallbackProxy, String secureProxyCheckUrl);
+    ICronetEngineBuilder setStoragePath(String value);
+    ICronetEngineBuilder setUserAgent(String userAgent);
+    String getDefaultUserAgent();
+    CronetEngine build();
+}