Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Addressed Paul's comments + rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/cronet/android/java/src/org/chromium/net/impl/UserAgent.java ('K') | « components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java
index b3dbbc4514faf0343ec14d92f717f4f078252868..4e6d533b00b90c2d7fe69e4933d8c9f499bcf395 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java
@@ -30,7 +30,8 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
private void setUp(QuicBidirectionalStreams enabled) throws Exception {
// Load library first to create MockCertVerifier.
System.loadLibrary("cronet_tests");
- CronetEngine.Builder builder = new CronetEngine.Builder(getContext());
+ ExperimentalCronetEngine.Builder builder =
+ new ExperimentalCronetEngine.Builder(getContext());
QuicTestServer.startQuicTestServer(getContext());
@@ -48,7 +49,8 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
builder.addQuicHint(QuicTestServer.getServerHost(), QuicTestServer.getServerPort(),
QuicTestServer.getServerPort());
- builder.setMockCertVerifierForTesting(QuicTestServer.createMockCertVerifier());
+ CronetTestUtil.setMockCertVerifierForTesting(
+ builder, QuicTestServer.createMockCertVerifier());
mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
}
@@ -68,11 +70,11 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
String path = "/simple.txt";
String quicURL = QuicTestServer.getServerURL() + path;
TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
- BidirectionalStream stream = new BidirectionalStream
- .Builder(quicURL, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
- .setHttpMethod("GET")
- .build();
+ BidirectionalStream stream =
+ mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
+ .setHttpMethod("GET")
+ .build();
stream.start();
callback.blockForDone();
assertTrue(stream.isDone());
@@ -98,15 +100,15 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
TestRequestFinishedListener requestFinishedListener =
new TestRequestFinishedListener(testExecutor);
mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
- BidirectionalStream stream = new BidirectionalStream
- .Builder(quicURL, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
- .addHeader("foo", "bar")
- .addHeader("empty", "")
- .addHeader("Content-Type", "zebra")
- .addRequestAnnotation("request annotation")
- .addRequestAnnotation(this)
- .build();
+ BidirectionalStream stream =
+ mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
+ .addRequestAnnotation("request annotation")
+ .addRequestAnnotation(this)
+ .addHeader("foo", "bar")
+ .addHeader("empty", "")
+ .addHeader("Content-Type", "zebra")
+ .build();
stream.start();
callback.blockForDone();
testExecutor.runAllTasks();
@@ -138,9 +140,9 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
callback.addWriteData("Test String".getBytes(), false);
callback.addWriteData("1234567890".getBytes(), false);
callback.addWriteData("woot!".getBytes(), true);
- BidirectionalStream stream = new BidirectionalStream
- .Builder(quicURL, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
+ BidirectionalStream stream = mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(
+ quicURL, callback, callback.getExecutor())
.delayRequestHeadersUntilFirstFlush(i == 0)
.addHeader("foo", "bar")
.addHeader("empty", "")
@@ -174,9 +176,9 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
callback.addWriteData("Test String".getBytes(), false);
callback.addWriteData("1234567890".getBytes(), false);
callback.addWriteData("woot!".getBytes(), true);
- BidirectionalStream stream = new BidirectionalStream
- .Builder(quicURL, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
+ BidirectionalStream stream = mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(
+ quicURL, callback, callback.getExecutor())
.delayRequestHeadersUntilFirstFlush(i == 0)
.addHeader("foo", "bar")
.addHeader("empty", "")
@@ -210,14 +212,14 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
super.onStreamReady(stream);
}
};
- BidirectionalStream stream = new BidirectionalStream
- .Builder(url, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
- .setHttpMethod("GET")
- .delayRequestHeadersUntilFirstFlush(i == 0)
- .addHeader("foo", "bar")
- .addHeader("empty", "")
- .build();
+ BidirectionalStream stream =
+ mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(url, callback, callback.getExecutor())
+ .setHttpMethod("GET")
+ .delayRequestHeadersUntilFirstFlush(i == 0)
+ .addHeader("foo", "bar")
+ .addHeader("empty", "")
+ .build();
// Flush before stream is started should not crash.
stream.flush();
@@ -248,14 +250,14 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
callback.addWriteData("Test String".getBytes(), true);
- BidirectionalStream stream = new BidirectionalStream
- .Builder(url, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
- .delayRequestHeadersUntilFirstFlush(i == 0)
- .addHeader("foo", "bar")
- .addHeader("empty", "")
- .addHeader("Content-Type", "zebra")
- .build();
+ BidirectionalStream stream =
+ mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(url, callback, callback.getExecutor())
+ .delayRequestHeadersUntilFirstFlush(i == 0)
+ .addHeader("foo", "bar")
+ .addHeader("empty", "")
+ .addHeader("Content-Type", "zebra")
+ .build();
stream.start();
callback.blockForDone();
assertTrue(stream.isDone());
@@ -276,11 +278,11 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
String quicURL = QuicTestServer.getServerURL() + path;
TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
- BidirectionalStream stream = new BidirectionalStream
- .Builder(quicURL, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
- .setHttpMethod("GET")
- .build();
+ BidirectionalStream stream =
+ mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
+ .setHttpMethod("GET")
+ .build();
stream.start();
callback.blockForDone();
assertTrue(stream.isDone());
@@ -316,13 +318,13 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
callback.addWriteData("1234567890".getBytes());
callback.addWriteData("woot!".getBytes());
- BidirectionalStream stream = new BidirectionalStream
- .Builder(quicURL, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
- .addHeader("foo", "bar")
- .addHeader("empty", "")
- .addHeader("Content-Type", "zebra")
- .build();
+ BidirectionalStream stream =
+ mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
+ .addHeader("foo", "bar")
+ .addHeader("empty", "")
+ .addHeader("Content-Type", "zebra")
+ .build();
stream.start();
callback.blockForDone();
assertTrue(stream.isDone());
@@ -342,11 +344,11 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
String path = "/simple.txt";
String quicURL = QuicTestServer.getServerURL() + path;
TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
- BidirectionalStream stream = new BidirectionalStream
- .Builder(quicURL, callback, callback.getExecutor(),
- mTestFramework.mCronetEngine)
- .setHttpMethod("GET")
- .build();
+ BidirectionalStream stream =
+ mTestFramework.mCronetEngine
+ .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
+ .setHttpMethod("GET")
+ .build();
stream.start();
callback.blockForDone();
assertTrue(stream.isDone());
@@ -358,9 +360,11 @@ public class BidirectionalStreamQuicTest extends CronetTestBase {
assertFalse(serialized_data.isEmpty());
// Create a new builder and verify that the |serialized_data| is deserialized correctly.
- CronetEngine.Builder builder = new CronetEngine.Builder(getContext());
+ ExperimentalCronetEngine.Builder builder =
+ new ExperimentalCronetEngine.Builder(getContext());
builder.enableQuic(true);
- builder.setMockCertVerifierForTesting(QuicTestServer.createMockCertVerifier());
+ CronetTestUtil.setMockCertVerifierForTesting(
+ builder, QuicTestServer.createMockCertVerifier());
builder.setCertVerifierData(serialized_data);
CronetTestFramework testFramework =
« components/cronet/android/java/src/org/chromium/net/impl/UserAgent.java ('K') | « components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698