components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java - Issue 2339223002: Cronet API Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

Issue 2339223002: Cronet API Refactoring (Closed)

Patch Set: Addressed Paul's comments + rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/impl/UserAgent.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/UserAgent.java ('k') | components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

index b08e40aa5f10edfb8b24758b3bd4b6223abe9bf1..2d565bec2a7204d2088a8fee8e9e9348bc9160b5 100644

--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

@@ -251,8 +251,8 @@ public class CronetHttpURLConnection extends HttpURLConnection {

if (connected) {

return;

}

- final UrlRequest.Builder requestBuilder = new UrlRequest.Builder(

- getURL().toString(), new CronetUrlRequestCallback(), mMessageLoop, mCronetEngine);

+ final UrlRequest.Builder requestBuilder = mCronetEngine.newUrlRequestBuilder(

+ getURL().toString(), new CronetUrlRequestCallback(), mMessageLoop);

if (doOutput) {

if (method.equals("GET")) {

method = "POST";