components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java - Issue 2339223002: Cronet API Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

Issue 2339223002: Cronet API Refactoring (Closed)

Patch Set: Addressed Paul's comments + rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java » ('j') | components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

index 6ab56a5b3e6c274a025e3c93cc59b4cd4f932b48..bbf20ad2214dde42d6706da39ed9e7020e891ca6 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

@@ -32,7 +32,7 @@ import javax.annotation.concurrent.GuardedBy;

@JNINamespace("cronet")

@VisibleForTesting

-public final class CronetUploadDataStream implements UploadDataSink {

+public final class CronetUploadDataStream extends UploadDataSink {

private static final String TAG = "CronetUploadDataStream";

// These are never changed, once a request starts.

private final Executor mExecutor;