Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Rebased onto Charles change + Paul's Comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
diff --git a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
index 0ca39e04d70f29fd8d97a5c32be5f01f20f4c461..b3385169bc5bf2d3bf33e4d351c4d3f1fba6b5b9 100644
--- a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
+++ b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
@@ -186,13 +186,13 @@ public class CronetPerfTestActivity extends Activity {
throw new IllegalArgumentException(
"Bad URL: " + host + ":" + port + "/" + resource);
}
- final CronetEngine.Builder cronetEngineBuilder =
- new CronetEngine.Builder(CronetPerfTestActivity.this);
- cronetEngineBuilder.setLibraryName("cronet_tests");
+ final ExperimentalCronetEngine.Builder cronetEngineBuilder =
+ new ExperimentalCronetEngine.Builder(CronetPerfTestActivity.this);
+ CronetTestUtil.setLibraryName(cronetEngineBuilder, "cronet_tests");
if (mProtocol == Protocol.QUIC) {
cronetEngineBuilder.enableQuic(true);
cronetEngineBuilder.addQuicHint(host, port, port);
- cronetEngineBuilder.setMockCertVerifierForTesting(
+ CronetTestUtil.setMockCertVerifierForTesting(cronetEngineBuilder,
MockCertVerifier.createMockCertVerifier(
new String[] {getConfigString("QUIC_CERT_FILE")}, true));
}
@@ -263,7 +263,7 @@ public class CronetPerfTestActivity extends Activity {
/**
* Transfer {@code mLength} bytes through HttpURLConnection in {@code mDirection} direction.
- * @param connection The HttpURLConnection to use for transfer.
+ * @param urlConnection The HttpURLConnection to use for transfer.
* @param buffer A buffer of length |mBufferSize| to use for transfer.
* @return {@code true} if transfer completed successfully.
*/
@@ -362,9 +362,9 @@ public class CronetPerfTestActivity extends Activity {
initiateRequest(buffer);
}
};
- final UrlRequest.Builder builder = new UrlRequest.Builder(mUrl.toString(),
- new Callback(buffer, completionCallback), mWorkQueueExecutor,
- mCronetEngine);
+ final UrlRequest.Builder builder =
+ mCronetEngine.newUrlRequestBuilder(mUrl.toString(),
+ new Callback(buffer, completionCallback), mWorkQueueExecutor);
if (mDirection == Direction.UP) {
builder.setUploadDataProvider(new Uploader(buffer), mWorkQueueExecutor);
builder.addHeader("Content-Type", "application/octet-stream");

Powered by Google App Engine
This is Rietveld 408576698