Cronet API Refactoring

components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.urlconnection;
 
-import org.chromium.net.CronetEngine;
+import org.chromium.net.impl.CronetEngineBase;
 
 import java.io.IOException;
 import java.net.Proxy;
 import java.net.URL;
 import java.net.URLConnection;
 import java.net.URLStreamHandler;
 
 /**
  * A {@link URLStreamHandler} that handles HTTP and HTTPS connections. One can use this class to
  * create {@link java.net.HttpURLConnection} instances implemented by Cronet; for example: <pre>
  *
  * CronetHttpURLStreamHandler streamHandler = new CronetHttpURLStreamHandler(myContext);
  * HttpURLConnection connection = (HttpURLConnection)streamHandler.openConnection(
  *         new URL("http://chromium.org"));</pre>
  * <b>Note:</b> Cronet's {@code HttpURLConnection} implementation is subject to some limitations
  * listed {@link CronetURLStreamHandlerFactory here}.
  */
 class CronetHttpURLStreamHandler extends URLStreamHandler {
-    private final CronetEngine mCronetEngine;
+    private final CronetEngineBase mCronetEngine;
 
-    public CronetHttpURLStreamHandler(CronetEngine cronetEngine) {
+    public CronetHttpURLStreamHandler(CronetEngineBase cronetEngine) {

[pauljensen, 2016/09/26 14:51:22]

why the change to CronetEngineBase?

[kapishnikov, 2016/09/27 18:38:26]

This is internal implementation. I think the less we reference the API classes
the better. Besides, we may need some internal CronetEngineBase methods that are
not exposed by the public API.

         mCronetEngine = cronetEngine;
     }
 
     /**
      * Establishes a new connection to the resource specified by the {@link URL} {@code url}.
      * @return an {@link java.net.HttpURLConnection} instance implemented by Cronet.
      */
     @Override
     public URLConnection openConnection(URL url) throws IOException {
         return mCronetEngine.openConnection(url);
     }
 
     /**
      * Establishes a new connection to the resource specified by the {@link URL} {@code url}
      * using the given proxy.
      * @return an {@link java.net.HttpURLConnection} instance implemented by Cronet.
      */
     @Override
     public URLConnection openConnection(URL url, Proxy proxy) throws IOException {
         return mCronetEngine.openConnection(url, proxy);
     }
 }