Cronet API Refactoring

components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+package org.chromium.net;
+
+import java.util.Date;
+import java.util.Set;
+
+/**
+ * Defines methods that the actual implementation of {@link CronetEngine.Builder} has to implement.
+ * {@code CronetEngine.Builder} uses this interface to delegate the calls.

[pauljensen, 2016/09/26 14:51:21]

add comment mentioning that documentation is at identically named
CronetEngine.Builder methods

[kapishnikov, 2016/09/27 18:38:25]

Done.

+ */
+public abstract class ICronetEngineBuilder {

[pauljensen, 2016/09/26 18:58:42]

this should be @hide...otherwise it appears in javadocs

[kapishnikov, 2016/09/27 18:38:25]

Done.

+    // Public API methods.
+    public abstract ICronetEngineBuilder addPublicKeyPins(String hostName, Set<byte[]> pinsSha256,
+            boolean includeSubdomains, Date expirationDate);
+    public abstract ICronetEngineBuilder addQuicHint(String host, int port, int alternatePort);
+    public abstract ICronetEngineBuilder enableDataReductionProxy(String key);
+    public abstract ICronetEngineBuilder enableHttp2(boolean value);
+    public abstract ICronetEngineBuilder enableHttpCache(int cacheMode, long maxSize);
+    public abstract ICronetEngineBuilder enableLegacyMode(boolean value);
+    public abstract ICronetEngineBuilder enablePublicKeyPinningBypassForLocalTrustAnchors(
+            boolean value);
+    public abstract ICronetEngineBuilder enableQuic(boolean value);
+    public abstract ICronetEngineBuilder enableSdch(boolean value);
+    public abstract ICronetEngineBuilder setExperimentalOptions(String options);
+    public abstract ICronetEngineBuilder setLibraryLoader(
+            CronetEngine.Builder.LibraryLoader loader);
+    public abstract ICronetEngineBuilder setStoragePath(String value);
+    public abstract ICronetEngineBuilder setUserAgent(String userAgent);
+    public abstract String getDefaultUserAgent();
+
+    // Experimental API methods.

[pauljensen, 2016/09/26 14:51:21]

mention that these methods must all have default implementations, as
experimental APIs may be remove in the future.

[kapishnikov, 2016/09/27 18:38:25]

Done.

+    public ICronetEngineBuilder enableNetworkQualityEstimator(boolean value) {
+        return this;
+    }
+
+    public ICronetEngineBuilder setCertVerifierData(String certVerifierData) {
+        return this;
+    }
+
+    public ICronetEngineBuilder setDataReductionProxyOptions(
+            String primaryProxy, String fallbackProxy, String secureProxyCheckUrl) {
+        return this;
+    }
+
+    // Build method.
+    public abstract CronetEngine build();

[pauljensen, 2016/09/26 14:51:21]

perhaps move this up to the "Public API methods" section, as that's what it is.

[kapishnikov, 2016/09/27 18:38:25]

Done.

+}