Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2478)

Unified Diff: components/browser_watcher/postmortem_report_collector.h

Issue 2339193003: A collector for postmortem reports (Closed)
Patch Set: Address first round of comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/postmortem_report_collector.h
diff --git a/components/browser_watcher/postmortem_report_collector.h b/components/browser_watcher/postmortem_report_collector.h
new file mode 100644
index 0000000000000000000000000000000000000000..8dec565e0468469eb17a2b6cd5b8c868c75929f2
--- /dev/null
+++ b/components/browser_watcher/postmortem_report_collector.h
@@ -0,0 +1,76 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Following an unclean shutdown, a stability report can be collected and
+// submitted for upload to a reporter.
+
+#ifndef COMPONENTS_BROWSER_WATCHER_POSTMORTEM_REPORT_COLLECTOR_H_
+#define COMPONENTS_BROWSER_WATCHER_POSTMORTEM_REPORT_COLLECTOR_H_
+
+#include <stdio.h>
+
+#include <memory>
+#include <set>
+#include <vector>
+
+#include "base/files/file.h"
+#include "base/files/file_path.h"
+#include "base/gtest_prod_util.h"
+#include "base/macros.h"
+#include "components/browser_watcher/stability_report.pb.h"
+#include "third_party/crashpad/crashpad/client/crash_report_database.h"
+
+namespace browser_watcher {
+
+// Collects unclean shutdown information and creates Crashpad minidumps.
+// TODO(manzagop): throttling, graceful handling of accumulating data.
+// TODO(manzagop): UMA metrics and some error logging.
+class PostmortemReportCollector {
+ public:
+ PostmortemReportCollector() = default;
+ virtual ~PostmortemReportCollector() = default;
+
+ // Collects postmortem stability reports from files found in |debug_info_dir|,
+ // relying on |debug_file_pattern| and |excluded_debug_files|. Reports are
+ // then wrapped in Crashpad reports, manufactured via |report_database|.
+ // Returns the number of actual postmortem reports found, irrespective of
+ // whether they were successfully converted to a Crashpad report (e.g. files
+ // that cannot be deleted will be counted, each time, even though the crash
+ // report will not be successfully produced).
+ int CollectAndSubmitForUpload(
+ const base::FilePath& debug_info_dir,
+ const base::FilePath::StringType& debug_file_pattern,
+ const std::set<base::FilePath>& excluded_debug_files,
+ crashpad::CrashReportDatabase* report_database);
+
+ private:
+ FRIEND_TEST_ALL_PREFIXES(PostmortemReportCollectorTest,
+ GetDebugStateFilePaths);
+ FRIEND_TEST_ALL_PREFIXES(PostmortemReportCollectorTest, CollectEmptyFile);
+ FRIEND_TEST_ALL_PREFIXES(PostmortemReportCollectorTest, CollectRandomFile);
+ FRIEND_TEST_ALL_PREFIXES(PostmortemReportCollectorCollectionTest,
+ CollectSuccess);
+
+ // Virtual for unittesting.
+ virtual std::vector<base::FilePath> GetDebugStateFilePaths(
+ const base::FilePath& debug_info_dir,
+ const base::FilePath::StringType& debug_file_pattern,
+ const std::set<base::FilePath>& excluded_debug_files);
+
+ // Virtual for unittesting.
+ // TODO(manzagop): move this for reuse in live scenario.
+ virtual std::unique_ptr<StabilityReport> Collect(
+ const base::FilePath& debug_state_file);
+
+ virtual bool WriteReportToMinidump(const StabilityReport& report,
+ const crashpad::UUID& client_id,
+ const crashpad::UUID& report_id,
+ base::PlatformFile minidump_file);
+
+ DISALLOW_COPY_AND_ASSIGN(PostmortemReportCollector);
+};
+
+} // namespace browser_watcher
+
+#endif // COMPONENTS_BROWSER_WATCHER_POSTMORTEM_REPORT_COLLECTOR_H_

Powered by Google App Engine
This is Rietveld 408576698