components/browser_watcher/DEPS - Issue 2339193003: A collector for postmortem reports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/browser_watcher/DEPS

Issue 2339193003: A collector for postmortem reports (Closed)

Patch Set: Address nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/metrics",	2 "+components/metrics",

	3 "+components/version_info",
	sky 2016/09/16 21:23:38 version_info depends upon ui/base. So, this change version_info depends upon ui/base. So, this changes makes me mildly nervous. But I can't readily see any problems. manzagop (departed) 2016/09/19 21:13:25 Acknowledged. Show quoted text On 2016/09/16 21:23:38, sky wrote: > version_info depends upon ui/base. So, this changes makes me mildly nervous. But > I can't readily see any problems. Acknowledged.
3 "+third_party/crashpad/crashpad",	4 "+third_party/crashpad/crashpad",

4 ]	5 ]

OLD	NEW