Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2339173005: Fix startup with system ICU (Closed)

Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix startup with system ICU We need to configure code to use built-in data from system library, not a separate file shipped with Chrome. BUG=551343 R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1fe2d072ef7d2294a911bb4ad0b33b8a4b7c4027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/linux/unbundle/icu.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Paweł Hajdan Jr.
4 years, 3 months ago (2016-09-15 15:40:13 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-15 19:35:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1fe2d072ef7d2294a911bb4ad0b33b8a4b7c4027 Cr-Commit-Position: refs/heads/master@{#418989}
4 years, 3 months ago (2016-09-15 21:45:56 UTC) #5
Paweł Hajdan Jr.
4 years, 3 months ago (2016-09-15 21:46:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1fe2d072ef7d2294a911bb4ad0b33b8a4b7c4027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698