Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/inspector/V8FunctionCall.cpp

Issue 2339173004: Revert of [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/V8DebuggerScript.cpp ('k') | src/inspector/V8HeapProfilerAgentImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 DCHECK(!info[i].IsEmpty()); 89 DCHECK(!info[i].IsEmpty());
90 } 90 }
91 91
92 int contextGroupId = V8Debugger::getGroupId(m_context); 92 int contextGroupId = V8Debugger::getGroupId(m_context);
93 if (contextGroupId) { 93 if (contextGroupId) {
94 m_inspector->client()->muteMetrics(contextGroupId); 94 m_inspector->client()->muteMetrics(contextGroupId);
95 m_inspector->muteExceptions(contextGroupId); 95 m_inspector->muteExceptions(contextGroupId);
96 } 96 }
97 v8::MicrotasksScope microtasksScope(m_context->GetIsolate(), 97 v8::MicrotasksScope microtasksScope(m_context->GetIsolate(),
98 v8::MicrotasksScope::kDoNotRunMicrotasks); 98 v8::MicrotasksScope::kDoNotRunMicrotasks);
99 v8::MaybeLocal<v8::Value> maybeResult = function->Call( 99 v8::MaybeLocal<v8::Value> maybeResult =
100 m_context, thisObject, static_cast<int>(m_arguments.size()), info.get()); 100 function->Call(m_context, thisObject, m_arguments.size(), info.get());
101 if (contextGroupId) { 101 if (contextGroupId) {
102 m_inspector->client()->unmuteMetrics(contextGroupId); 102 m_inspector->client()->unmuteMetrics(contextGroupId);
103 m_inspector->unmuteExceptions(contextGroupId); 103 m_inspector->unmuteExceptions(contextGroupId);
104 } 104 }
105 105
106 v8::Local<v8::Value> result; 106 v8::Local<v8::Value> result;
107 if (!maybeResult.ToLocal(&result)) return v8::Local<v8::Value>(); 107 if (!maybeResult.ToLocal(&result)) return v8::Local<v8::Value>();
108 return result; 108 return result;
109 } 109 }
110 110
111 } // namespace v8_inspector 111 } // namespace v8_inspector
OLDNEW
« no previous file with comments | « src/inspector/V8DebuggerScript.cpp ('k') | src/inspector/V8HeapProfilerAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698