Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2339163004: Revert of Moving CRD Windows targets to subdirectories. (Closed)

Created:
4 years, 3 months ago by msw
Modified:
4 years, 3 months ago
Reviewers:
brettw, Hzj_jie, nicholss, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moving CRD Windows targets to subdirectories. (patchset #4 id:770001 of https://codereview.chromium.org/2308813002/ ) Reason for revert: https://build.chromium.org/p/chromium/builders/Win/builds/47116/ FAILED: obj/remoting/host/win/remoting_core/chromoting_lib.res C:/b/depot_tools/python276_bin/python.exe ... ../../remoting/host/win/chromoting_lib.rc(5) : error RC2135 : file not found: remoting/host/chromoting_lib.tlb Original issue's description: > Moving CRD Windows targets to subdirectories. > > This is the windows host focused GN rewrite for Remoting Host. This > work attempts to simplify the build for Remoting so it can be more > easily understood and maintained. This is done by pushing more of the target config checking deeper into the platform specific targets and > producing build files that are more in-line with best-practice GN style. > > Committed: https://crrev.com/ac59f3fd88f185f04e1cd177fcc2d05a425308e6 > Cr-Commit-Position: refs/heads/master@{#418668} TBR=zijiehe@chromium.org,joedow@chromium.org,brettw@chromium.org,nicholss@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8a1b5fea920fd2368abb28a89981dd79b736ee8e Cr-Commit-Position: refs/heads/master@{#418686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+644 lines, -859 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/BUILD.gn View 5 chunks +10 lines, -25 lines 0 comments Download
M remoting/build/config/BUILD.gn View 2 chunks +0 lines, -17 lines 0 comments Download
M remoting/host/BUILD.gn View 18 chunks +620 lines, -82 lines 0 comments Download
M remoting/host/desktop_session_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/host_event_logger_win.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/installer/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D remoting/host/installer/win/BUILD.gn View 1 chunk +0 lines, -143 lines 0 comments Download
D remoting/host/installer/win/generate_clsids.gni View 1 chunk +0 lines, -19 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/security_key/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/setup/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/win/BUILD.gn View 1 chunk +0 lines, -476 lines 0 comments Download
M remoting/host/win/chromoting_module.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_desktop_session.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
D remoting/tools/BUILD.gn View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
msw
Created Revert of Moving CRD Windows targets to subdirectories.
4 years, 3 months ago (2016-09-14 21:43:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339163004/1
4 years, 3 months ago (2016-09-14 21:44:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 21:45:54 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 21:48:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a1b5fea920fd2368abb28a89981dd79b736ee8e
Cr-Commit-Position: refs/heads/master@{#418686}

Powered by Google App Engine
This is Rietveld 408576698