Revert of BackgroundGradientView: -drawBackground: → -drawRect:

Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2 id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
>
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
>
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
>
> BUG=589943
>
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647018
Committed: https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf
Cr-Commit-Position: refs/heads/master@{#418714}

[Sidney San Martín, 2016-09-14 22:12:54]

The CQ bit was checked by sdy@chromium.org

[Sidney San Martín, 2016-09-14 22:12:54]

Created Revert of BackgroundGradientView: -drawBackground: → -drawRect:

[commit-bot: I haz the power, 2016-09-14 22:13:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 22:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 22:13:29]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nico, 2016-09-14 22:25:10]

lgtm

[Nico, 2016-09-14 22:25:14]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-14 22:25:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sidney San Martín, 2016-09-14 22:26:05]

Description was changed from

==========
Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2
id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
> 
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
> 
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
> 
> BUG=589943
> 
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=589943
==========

to

==========
Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2
id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
> 
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
> 
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
> 
> BUG=589943
> 
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647018
==========

[Sidney San Martín, 2016-09-14 22:26:33]

The CQ bit was unchecked by sdy@chromium.org

[Sidney San Martín, 2016-09-14 22:26:52]

The CQ bit was checked by sdy@chromium.org

[commit-bot: I haz the power, 2016-09-14 22:27:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 23:10:12]

Description was changed from

==========
Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2
id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
> 
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
> 
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
> 
> BUG=589943
> 
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647018
==========

to

==========
Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2
id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
> 
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
> 
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
> 
> BUG=589943
> 
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647018
==========

[commit-bot: I haz the power, 2016-09-14 23:10:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-14 23:13:14]

Description was changed from

==========
Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2
id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
> 
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
> 
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
> 
> BUG=589943
> 
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647018
==========

to

==========
Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2
id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
>
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
>
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
>
> BUG=589943
>
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647018

Committed: https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf
Cr-Commit-Position: refs/heads/master@{#418714}
==========

[commit-bot: I haz the power, 2016-09-14 23:13:15]

Patchset 1 (id:??) landed as
https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf
Cr-Commit-Position: refs/heads/master@{#418714}