Fix NavigationControllerBrowserTest.PageIDUpdatedOnPageReplacement.

Fix NavigationControllerBrowserTest.PageIDUpdatedOnPageReplacement.

Currently the test passes even without the original fix for bug 611679
(https://codereview.chromium.org/1978793002/patch/40001/50002).
I checked that this CL makes the test proper again (it fails without
the bug fix).

Discussed in https://codereview.chromium.org/2225053002/
(see most recent comments).

BUG=611679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c3bbb640c6513956b9fe9dc5e01baf5659019de0
Cr-Commit-Position: refs/heads/master@{#418801}

[Alexander Semashko, 2016-09-14 10:35:28]

Description was changed from

==========
Fix NavigationControllerBrowserTest.PageIDUpdatedOnPageReplacement.

Currently the test passes even without the original fix for bug 611679
(https://codereview.chromium.org/1978793002/patch/40001/50002).
I checked that this CL makes the test proper again (it fails without
the bug fix).

Discussed in https://codereview.chromium.org/2225053002/
(see most recent comments).

BUG=611679
==========

to

==========
Fix NavigationControllerBrowserTest.PageIDUpdatedOnPageReplacement.

Currently the test passes even without the original fix for bug 611679
(https://codereview.chromium.org/1978793002/patch/40001/50002).
I checked that this CL makes the test proper again (it fails without
the bug fix).

Discussed in https://codereview.chromium.org/2225053002/
(see most recent comments).

BUG=611679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Alexander Semashko, 2016-09-14 10:36:32]

ahest@yandex-team.ru changed reviewers:
+ nasko@chromium.org

[nasko, 2016-09-14 22:33:22]

Thanks for the fix! LGTM

https://codereview.chromium.org/2339133002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2339133002/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:586:
shell()->web_contents()->GetRenderProcessHost()->GetID();
nit: Usually SiteInstance is used for comparison whether cross-process
navigation has occurred.

[Alexander Semashko, 2016-09-15 07:25:33]

The CQ bit was checked by ahest@yandex-team.ru

[commit-bot: I haz the power, 2016-09-15 07:25:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 07:57:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 07:59:14]

Description was changed from

==========
Fix NavigationControllerBrowserTest.PageIDUpdatedOnPageReplacement.

Currently the test passes even without the original fix for bug 611679
(https://codereview.chromium.org/1978793002/patch/40001/50002).
I checked that this CL makes the test proper again (it fails without
the bug fix).

Discussed in https://codereview.chromium.org/2225053002/
(see most recent comments).

BUG=611679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix NavigationControllerBrowserTest.PageIDUpdatedOnPageReplacement.

Currently the test passes even without the original fix for bug 611679
(https://codereview.chromium.org/1978793002/patch/40001/50002).
I checked that this CL makes the test proper again (it fails without
the bug fix).

Discussed in https://codereview.chromium.org/2225053002/
(see most recent comments).

BUG=611679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c3bbb640c6513956b9fe9dc5e01baf5659019de0
Cr-Commit-Position: refs/heads/master@{#418801}
==========

[commit-bot: I haz the power, 2016-09-15 07:59:15]

Patchset 1 (id:??) landed as
https://crrev.com/c3bbb640c6513956b9fe9dc5e01baf5659019de0
Cr-Commit-Position: refs/heads/master@{#418801}