Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 233913002: trychange.py: create patch refs in refs/patches/ (Closed)

Created:
6 years, 8 months ago by nodir
Modified:
6 years, 8 months ago
Reviewers:
agable, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

trychange.py: create patch refs in refs/patches/ In Git-mode, the previous version of code created a ref in refs/heads/refs/patches/... instead of refs/patches/.... This commit fixes the problem. R=maruel@chromium.org, agable@chromium.org BUG=362264 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263439

Patch Set 1 #

Total comments: 4

Patch Set 2 : added TODO about commit-tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M trychange.py View 1 2 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nodir
6 years, 8 months ago (2014-04-10 21:14:49 UTC) #1
agable
LGTM. It would be cleaner to directly commit-tree instead of having the temp orphan branch, ...
6 years, 8 months ago (2014-04-11 21:44:59 UTC) #2
nodir
Please lgtm https://codereview.chromium.org/231663005/ https://codereview.chromium.org/233913002/diff/20001/trychange.py File trychange.py (right): https://codereview.chromium.org/233913002/diff/20001/trychange.py#newcode514 trychange.py:514: def _PrepareDescriptionAndPatchFiles(description, options, use_username=True): This is ...
6 years, 8 months ago (2014-04-11 23:58:20 UTC) #3
nodir
The CQ bit was checked by nodir@chromium.org
6 years, 8 months ago (2014-04-12 01:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nodir@chromium.org/233913002/40001
6 years, 8 months ago (2014-04-12 01:13:14 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 01:15:05 UTC) #6
Message was sent while issue was closed.
Change committed as 263439

Powered by Google App Engine
This is Rietveld 408576698