Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2339123003: Revert of Set crash key if WM_QUIT message is received on GPU message loop. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set crash key if WM_QUIT message is received on GPU message loop. (patchset #2 id:20001 of https://codereview.chromium.org/2342713002/ ) Reason for revert: Forgot key registration. Original issue's description: > Set crash key if WM_QUIT message is received on GPU message loop. > > Threads seem to be exiting unexpectedly, so to help debugging set a > crash key if an unexpected WM_QUIT message is received. > > BUG=647068 > > Committed: https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c > Cr-Commit-Position: refs/heads/master@{#418753} TBR=dcheng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647068 Committed: https://crrev.com/0df831ca41ce92ee90106db6996ddbb1887a0238 Cr-Commit-Position: refs/heads/master@{#418790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M base/message_loop/message_pump_win.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbauman
Created Revert of Set crash key if WM_QUIT message is received on GPU message loop.
4 years, 3 months ago (2016-09-15 05:32:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339123003/1
4 years, 3 months ago (2016-09-15 05:32:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 05:33:23 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 05:34:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0df831ca41ce92ee90106db6996ddbb1887a0238
Cr-Commit-Position: refs/heads/master@{#418790}

Powered by Google App Engine
This is Rietveld 408576698