Use InstallEvent even if ForeignFetch is disabled

Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced only for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e44245840cb5d4e
But according to the spec we should use InstallEvent interface for install event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=

Committed: https://crrev.com/707632096793d6ff645a1a4583956ab53f2398ab
Cr-Commit-Position: refs/heads/master@{#418725}

[horo, 2016-09-14 05:25:58]

Description was changed from

==========
Use InstallEvent even if ForeignFetch is disabled

BUG=
==========

to

==========
Use InstallEvent interface even if ForeignFetch is disabled

BUG=
==========

[horo, 2016-09-14 05:27:47]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 05:28:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-09-14 06:21:35]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 06:21:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-09-14 06:34:29]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2016-09-14 06:34:48]

falken@
PTAL.

[falken, 2016-09-14 06:57:03]

For the historical record, can you add to the CL description why this change is
needed? I guess, InstallEvent was implemented for foreign fetch only, but it's
actually long been part of the service worker spec.

I think we have test coverage with
virtual/stable/http/tests/serviceworker/webexposed. Those expectations needs
updating no?

[horo, 2016-09-14 07:12:43]

Description was changed from

==========
Use InstallEvent interface even if ForeignFetch is disabled

BUG=
==========

to

==========
Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e4424584...
But according to the spec we should use InstallEvent interface for install
event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=
==========

[horo, 2016-09-14 07:13:14]

Description was changed from

==========
Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e4424584...
But according to the spec we should use InstallEvent interface for install
event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=
==========

to

==========
Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced only for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e4424584...
But according to the spec we should use InstallEvent interface for install
event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=
==========

[horo, 2016-09-14 07:14:36]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[horo, 2016-09-14 07:14:42]

On 2016/09/14 06:57:03, falken wrote:
> For the historical record, can you add to the CL description why this change
is
> needed? I guess, InstallEvent was implemented for foreign fetch only, but it's
> actually long been part of the service worker spec.
> 
> I think we have test coverage with
> virtual/stable/http/tests/serviceworker/webexposed. Those expectations needs
> updating no?

done

[commit-bot: I haz the power, 2016-09-14 07:14:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-09-14 07:17:19]

thanks, lgtm

[horo, 2016-09-14 07:50:11]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 07:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-09-14 07:57:05]

horo@chromium.org changed reviewers:
+ haraken@chromium.org

[horo, 2016-09-14 07:57:06]

haraken@
Could you please review this?

[haraken, 2016-09-14 08:00:24]

LGTM

[horo, 2016-09-14 10:08:33]

The CQ bit was unchecked by horo@chromium.org

[horo, 2016-09-14 10:08:40]

The CQ bit was checked by horo@chromium.org

[horo, 2016-09-14 10:08:41]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2339083002/#ps60001
(title: "fix global-interface-listing-service-worker-expected.txt")

[commit-bot: I haz the power, 2016-09-14 10:08:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 10:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 10:16:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[horo, 2016-09-14 10:53:44]

horo@chromium.org changed reviewers:
+ tkent@chromium.org

[horo, 2016-09-14 10:53:44]

tkent@
Could you please review global-interface-listing-service-worker-expected.txt?

[tkent, 2016-09-14 23:07:53]

lgtm.  This is a minor change, and I think we don't need intent-to-ship.

[horo, 2016-09-15 00:28:40]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:35:57]

Description was changed from

==========
Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced only for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e4424584...
But according to the spec we should use InstallEvent interface for install
event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=
==========

to

==========
Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced only for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e4424584...
But according to the spec we should use InstallEvent interface for install
event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=
==========

[commit-bot: I haz the power, 2016-09-15 00:35:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 00:37:52]

Description was changed from

==========
Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced only for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e4424584...
But according to the spec we should use InstallEvent interface for install
event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=
==========

to

==========
Use InstallEvent interface even if ForeignFetch is disabled

InstallEvent interface was introduced only for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e4424584...
But according to the spec we should use InstallEvent interface for install
event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=

Committed: https://crrev.com/707632096793d6ff645a1a4583956ab53f2398ab
Cr-Commit-Position: refs/heads/master@{#418725}
==========

[commit-bot: I haz the power, 2016-09-15 00:37:53]

Patchset 4 (id:??) landed as
https://crrev.com/707632096793d6ff645a1a4583956ab53f2398ab
Cr-Commit-Position: refs/heads/master@{#418725}