Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/wasm/ast-decoder.cc

Issue 2339053003: [V8][Wasm] Wasm throws. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addresses comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-wasm.cc ('k') | test/mjsunit/wasm/exceptions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/ast-decoder.cc
diff --git a/src/wasm/ast-decoder.cc b/src/wasm/ast-decoder.cc
index 4795f84e7a8440ab3c57d0782a87090e8dd54c8e..7083279fe625897c6465fafded4a7ac7b035c4e0 100644
--- a/src/wasm/ast-decoder.cc
+++ b/src/wasm/ast-decoder.cc
@@ -667,9 +667,8 @@ class WasmFullDecoder : public WasmDecoder {
}
case kExprThrow: {
CHECK_PROTOTYPE_OPCODE(wasm_eh_prototype);
- Pop(0, kAstI32);
-
- // TODO(jpp): start exception propagation.
+ Value value = Pop(0, kAstI32);
+ BUILD(Throw, value.node);
break;
}
case kExprTry: {
« no previous file with comments | « src/runtime/runtime-wasm.cc ('k') | test/mjsunit/wasm/exceptions.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698