[V8][Wasm] Wasm throws.

[V8][Wasm] Wasm throws.

This CL implements the throw wasm opcode. This is a pre-requisite for
implementing try-catches in wasm.

BUG=

Committed: https://crrev.com/5855e44c1a193c389d9cd899461092bfbce923a0
Cr-Commit-Position: refs/heads/master@{#39449}

[John, 2016-09-14 13:18:29]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 13:18:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-09-14 13:20:58]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 13:21:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-09-14 13:21:23]

jpp@chromium.org changed reviewers:
+ bradnelson@chromium.org, titzer@chromium.org

[commit-bot: I haz the power, 2016-09-14 13:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 13:34:47]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[John, 2016-09-14 13:56:07]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 13:56:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 14:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 14:14:37]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[John, 2016-09-15 12:19:21]

jpp@chromium.org changed reviewers:
+ ahaas@chromium.org

[John, 2016-09-15 12:19:45]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 12:19:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-09-15 12:33:36]

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
File src/runtime/runtime-wasm.cc (right):

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
src/runtime/runtime-wasm.cc:25: CHECK(args[0]->ToUint32(&delta_pages));
nit: I know this is not your code, but for bonus points this could use
CONVERT_UINT32_ARG_CHECKED as well.

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
src/runtime/runtime-wasm.cc:126: Object* lower = args[0];
nit: Please use CONVERT_SMI_ARG_CHECKED here.

[John, 2016-09-15 12:42:05]

ptal

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
File src/runtime/runtime-wasm.cc (right):

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
src/runtime/runtime-wasm.cc:25: CHECK(args[0]->ToUint32(&delta_pages));
On 2016/09/15 12:33:36, Michael Starzinger wrote:
> nit: I know this is not your code, but for bonus points this could use
> CONVERT_UINT32_ARG_CHECKED as well.

CONVERT_UINT32_ARG_CHECKED is not available. I changed to
CONVERT_INT32_ARG_CHECKED, which can be a problem if delta_pages is > 2**32 -1.
Should I keep my change, or revert, or add a new macro?

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
src/runtime/runtime-wasm.cc:126: Object* lower = args[0];
On 2016/09/15 12:33:36, Michael Starzinger wrote:
> nit: Please use CONVERT_SMI_ARG_CHECKED here.

Done.

[Michael Starzinger, 2016-09-15 12:51:08]

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
File src/runtime/runtime-wasm.cc (right):

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
src/runtime/runtime-wasm.cc:25: CHECK(args[0]->ToUint32(&delta_pages));
On 2016/09/15 12:42:05, John wrote:
> On 2016/09/15 12:33:36, Michael Starzinger wrote:
> > nit: I know this is not your code, but for bonus points this could use
> > CONVERT_UINT32_ARG_CHECKED as well.
> 
> CONVERT_UINT32_ARG_CHECKED is not available. I changed to
> CONVERT_INT32_ARG_CHECKED, which can be a problem if delta_pages is > 2**32
-1.
> Should I keep my change, or revert, or add a new macro?

https://cs.chromium.org/chromium/src/v8/src/runtime/runtime-utils.h?q=CONVERT...

[titzer, 2016-09-15 12:53:28]

lgtm

https://codereview.chromium.org/2339053003/diff/100001/src/compiler/wasm-comp...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2339053003/diff/100001/src/compiler/wasm-comp...
src/compiler/wasm-compiler.cc:1709: // Pass the thrown value as two SMIs:
Please leave a TODO here, since I think we all agreed this was sad :(

[John, 2016-09-15 14:02:49]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 14:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-09-15 14:03:08]

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
File src/runtime/runtime-wasm.cc (right):

https://codereview.chromium.org/2339053003/diff/80001/src/runtime/runtime-was...
src/runtime/runtime-wasm.cc:25: CHECK(args[0]->ToUint32(&delta_pages));
On 2016/09/15 12:51:08, Michael Starzinger wrote:
> On 2016/09/15 12:42:05, John wrote:
> > On 2016/09/15 12:33:36, Michael Starzinger wrote:
> > > nit: I know this is not your code, but for bonus points this could use
> > > CONVERT_UINT32_ARG_CHECKED as well.
> > 
> > CONVERT_UINT32_ARG_CHECKED is not available. I changed to
> > CONVERT_INT32_ARG_CHECKED, which can be a problem if delta_pages is > 2**32
> -1.
> > Should I keep my change, or revert, or add a new macro?
> 
>
https://cs.chromium.org/chromium/src/v8/src/runtime/runtime-utils.h?q=CONVERT...

Done.

https://codereview.chromium.org/2339053003/diff/100001/src/compiler/wasm-comp...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2339053003/diff/100001/src/compiler/wasm-comp...
src/compiler/wasm-compiler.cc:1709: // Pass the thrown value as two SMIs:
On 2016/09/15 12:53:28, titzer wrote:
> Please leave a TODO here, since I think we all agreed this was sad :(

Done.

[Michael Starzinger, 2016-09-15 14:06:02]

Thanks. LGTM on the "runtime" part FWIW.

[ahaas, 2016-09-15 14:11:28]

ahaas@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[ahaas, 2016-09-15 14:11:29]

lgtm

[commit-bot: I haz the power, 2016-09-15 14:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 14:29:27]

Dry run: This issue passed the CQ dry run.

[John, 2016-09-15 15:01:53]

The CQ bit was checked by jpp@chromium.org

[John, 2016-09-15 15:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2339053003/#ps120001
(title: "Addresses comments.")

[commit-bot: I haz the power, 2016-09-15 15:02:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 15:04:16]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-15 15:04:56]

Description was changed from

==========
[V8][Wasm] Wasm throws.

This CL implements the throw wasm opcode. This is a pre-requisite for
implementing try-catches in wasm.

BUG=
==========

to

==========
[V8][Wasm] Wasm throws.

This CL implements the throw wasm opcode. This is a pre-requisite for
implementing try-catches in wasm.

BUG=

Committed: https://crrev.com/5855e44c1a193c389d9cd899461092bfbce923a0
Cr-Commit-Position: refs/heads/master@{#39449}
==========

[commit-bot: I haz the power, 2016-09-15 15:04:57]

Patchset 7 (id:??) landed as
https://crrev.com/5855e44c1a193c389d9cd899461092bfbce923a0
Cr-Commit-Position: refs/heads/master@{#39449}