Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2339053002: Change summaries setter generation to allow properties named 'value'. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change summaries setter generation to allow properties named 'value'. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/35bf41691e5834c9f44841db13a84c2fc8bf88ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -557 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 239 chunks +553 lines, -553 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-09-14 01:40:48 UTC) #1
scheglov
ping
4 years, 3 months ago (2016-09-15 02:54:45 UTC) #2
Paul Berry
lgtm. Sorry for the slow response.
4 years, 3 months ago (2016-09-15 08:49:10 UTC) #3
scheglov
4 years, 3 months ago (2016-09-15 14:08:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35bf41691e5834c9f44841db13a84c2fc8bf88ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698