Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2339033005: Revert of [heap] Decouple old generation allocation limit from external memory. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Decouple old generation allocation limit from external memory. (patchset #1 id:1 of https://codereview.chromium.org/2329993002/ ) Reason for revert: Regressions in telemetry benchmarks: crbug.com/646819. Original issue's description: > [heap] Decouple old generation allocation limit from external memory. > > We check for external memory limit in Heap::ReportExternalMemoryPressure. > > BUG=chromium:616434 > > Committed: https://crrev.com/672d079ccba686019fa1457c83b42c2e692ef88b > Cr-Commit-Position: refs/heads/master@{#39374} TBR=hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:616434 Committed: https://crrev.com/eeb4f28aed721c343d43be6e454fafba4c0f7ea6 Cr-Commit-Position: refs/heads/master@{#39442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M src/heap/heap.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ulan
Created Revert of [heap] Decouple old generation allocation limit from external memory.
4 years, 3 months ago (2016-09-15 09:41:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339033005/1
4 years, 3 months ago (2016-09-15 09:41:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 10:13:47 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 10:14:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeb4f28aed721c343d43be6e454fafba4c0f7ea6
Cr-Commit-Position: refs/heads/master@{#39442}

Powered by Google App Engine
This is Rietveld 408576698