Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2339033003: bluetooth: Perform an LE scan only (Closed)

Created:
4 years, 3 months ago by ortuno
Modified:
4 years, 3 months ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Perform an LE scan only There isn't much support from platforms and devices for GATT over BR/EDR so to avoid confusing users and wasting power, perform a LE scan only. BUG=643625 Committed: https://crrev.com/447f53595b1c768936bc38f37c77d8c497a519f3 Cr-Commit-Position: refs/heads/master@{#418792}

Patch Set 1 #

Patch Set 2 : Add decision to doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/README.md View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
ortuno
scheib: PTAL
4 years, 3 months ago (2016-09-14 05:44:58 UTC) #2
scheib
LGTM but please add this explanation also to https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/modules/bluetooth/README.md and or https://docs.google.com/document/d/1MBOLc1J09xhmEy9As17Rii4asM7u60LluRIv-OPPARM/edit#
4 years, 3 months ago (2016-09-14 17:17:23 UTC) #8
ortuno
Done on both: https://docs.google.com/document/d/1MBOLc1J09xhmEy9As17Rii4asM7u60LluRIv-OPPARM/edit?pli=1#heading=h.n0ambri0ryju
4 years, 3 months ago (2016-09-15 01:48:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339033003/20001
4 years, 3 months ago (2016-09-15 01:48:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/280136)
4 years, 3 months ago (2016-09-15 03:24:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339033003/20001
4 years, 3 months ago (2016-09-15 04:09:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/280197)
4 years, 3 months ago (2016-09-15 05:45:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339033003/20001
4 years, 3 months ago (2016-09-15 05:47:15 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 06:21:57 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 06:24:06 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/447f53595b1c768936bc38f37c77d8c497a519f3
Cr-Commit-Position: refs/heads/master@{#418792}

Powered by Google App Engine
This is Rietveld 408576698