Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2338993003: Fix missing dependency of //extensions:extensions_renderer_resources. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
btolsch
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing dependency of //extensions:extensions_renderer_resources. This resolves "ninja explain" failures after: https://chromium.googlesource.com/chromium/src/+/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643 e.g. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/297782 ninja explain: restat of output gen/extensions/extensions_renderer_resources_stamp.d.stamp older than most recent input /b/c/b/linux/src/out/Release/gen/mojo/common/common_custom_types.mojom.js (0 vs 1473884135) BUG=629375 TBR=btolsch@chromium.org NOTRY=true Committed: https://crrev.com/41d79bc2e20416004dd0b8e4f4f4b040cab45a56 Cr-Commit-Position: refs/heads/master@{#418672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338993003/1
4 years, 3 months ago (2016-09-14 21:02:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 21:08:30 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 21:12:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d79bc2e20416004dd0b8e4f4f4b040cab45a56
Cr-Commit-Position: refs/heads/master@{#418672}

Powered by Google App Engine
This is Rietveld 408576698