Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2338973002: [DevTools] removed PROTOCOL_ARRAY_LENGTH array (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] removed PROTOCOL_ARRAY_LENGTH array This macro is unused in codebase. BUG=chromium:635948 R=dgozman@chromium.org Committed: https://crrev.com/c571d53098e02d471a44f30132a2fb9144c75cf0 Cr-Commit-Position: refs/heads/master@{#418419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/lib/Collections_h.template View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kozy
This macro is implemented with zero length array that produces warning during V8 compilation. It ...
4 years, 3 months ago (2016-09-13 21:38:35 UTC) #1
dgozman
lgtm as long as it compiles
4 years, 3 months ago (2016-09-13 22:06:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338973002/1
4 years, 3 months ago (2016-09-13 22:12:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 23:48:08 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 23:52:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c571d53098e02d471a44f30132a2fb9144c75cf0
Cr-Commit-Position: refs/heads/master@{#418419}

Powered by Google App Engine
This is Rietveld 408576698