Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 2338963002: Store, use and send etags. (Closed)
Patch Set: comments addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/resource_multibuffer_data_provider.cc » ('j') | media/blink/url_index.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_data_source_unittest.cc
diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc
index 6242881226f5890d727b6f0e0842256b5bd582e6..489047c14f1609dfd24c40f00ff0955b74f27f8e 100644
--- a/media/blink/multibuffer_data_source_unittest.cc
+++ b/media/blink/multibuffer_data_source_unittest.cc
@@ -466,8 +466,9 @@ class MultibufferDataSourceTest : public testing::Test {
int data_source_bitrate() { return data_source_->bitrate_; }
double data_source_playback_rate() { return data_source_->playback_rate_; }
bool is_local_source() { return data_source_->assume_fully_buffered(); }
+ scoped_refptr<UrlData> url_data() { return data_source_->url_data_; }
void set_might_be_reused_from_cache_in_future(bool value) {
- data_source_->url_data_->set_cacheable(value);
+ url_data()->set_cacheable(value);
}
protected:
@@ -1478,4 +1479,18 @@ TEST_F(MultibufferDataSourceTest, DidPassCORSAccessTest) {
EXPECT_TRUE(data_source_->DidPassCORSAccessCheck());
}
+TEST_F(MultibufferDataSourceTest, EtagTest) {
+ Initialize(kHttpUrl, true);
+
+ EXPECT_CALL(host_, SetTotalBytes(response_generator_->content_length()));
+ WebURLResponse response = response_generator_->Generate206(0);
+ const std::string etag("\"arglebargle glop-glyf?\"");
+ response.setHTTPHeaderField(WebString::fromUTF8("Etag"),
+ WebString::fromUTF8(etag));
+ Respond(response);
+ EXPECT_CALL(host_, AddBufferedByteRange(0, kDataSize));
+ ReceiveData(kDataSize);
+
+ EXPECT_EQ(url_data()->etag(), etag);
+}
} // namespace media
« no previous file with comments | « no previous file | media/blink/resource_multibuffer_data_provider.cc » ('j') | media/blink/url_index.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698