Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2338923003: MacOS handle cmd+V directly in WebKit (Closed)

Created:
4 years, 3 months ago by yamaxim
Modified:
3 years, 9 months ago
CC:
chongz, dtapuska, blink-reviews, chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacOS handle cmd+V directly in WebKit In MacOS paste text into webpages work very slowly(as compared with Win) because we send input message to renderer, than back to browser process, do blinking by top menu item, and than send message for paste again to renderer. You can copy one symbol and try to paste it in any webpage by holding cmd+v this will be very slow. This CL do handle input cmd+V message immediately be renderer without sending it back to browser process, but has side effects because we will don't blinking by top menu item. R=ojan@chromium.org,aelias@chromium.org BUG=647183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingBehavior.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
yamaxim
4 years, 3 months ago (2016-09-14 15:30:33 UTC) #1
aelias_OOO_until_Jul13
OK, I can observe the slowness of repeated paste on OS X, but I'm not ...
4 years, 3 months ago (2016-09-14 18:19:12 UTC) #2
yamaxim
On 2016/09/14 18:19:12, aelias wrote: > OK, I can observe the slowness of repeated paste ...
4 years, 3 months ago (2016-09-15 10:21:17 UTC) #4
yamaxim
4 years, 3 months ago (2016-09-15 10:21:47 UTC) #5
aelias_OOO_until_Jul13
4 years, 3 months ago (2016-09-15 18:13:56 UTC) #6
On 2016/09/15 at 10:21:17, yamaxim wrote:
> On 2016/09/14 18:19:12, aelias wrote:
> > OK, I can observe the slowness of repeated paste on OS X, but I'm not sure
that
> > this is the right fix.  Firefox and Safari both blink the Edit menu even as
they
> > paste faster than Chrome.  I'd suggest filing a bug describing the symptoms
and
> > attach a chrome://tracing profile taken during repeated paste (with Blink,
Input
> > and Browser categories at a minimum).
> 
> So, I created  https://bugs.chromium.org/p/chromium/issues/detail?id=647183
> Should I delete this CL?

Thanks.  Please don't delete the CL since that would delete history of
discussion/proposals.  If we choose not to land a CL, it's better to "Close"
instead.

Powered by Google App Engine
This is Rietveld 408576698