Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issue 2338893002: [Merge to 54] Fix CPDFSDK_PageView cleanup. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/chromium/2840
Project:
pdfium
Visibility:
Public.

Description

[Merge to 54] Fix CPDFSDK_PageView cleanup. In https://pdfium.googlesource.com/pdfium/+/461eeafe191068ac8c32f2717907fc6a22a667d2 we moved the map cleanup for the page view to happen before the page view was destroyed and before we killed the annotation focus. The map removal must happen before the pageview is destroyed, but must happen after we've killed the annotation focus in order to not create duplicate page views which point to the same page. BUG=chromium:645122 R=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2320253002 Committed: https://pdfium.googlesource.com/pdfium/+/ccf7734cad06cb9383d55190d6cd6aa6ccc91ab2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL (merge clean)
4 years, 3 months ago (2016-09-13 18:25:26 UTC) #2
Tom Sepez
RS LGTM
4 years, 3 months ago (2016-09-13 18:40:24 UTC) #3
dsinclair
4 years, 3 months ago (2016-09-13 18:51:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ccf7734cad06cb9383d55190d6cd6aa6ccc91ab2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698