Map in LookUpGlyphBitmap even when unsuccessful

Map glyph bitmap in LookUpGlyphBitmap even when unsuccessful

CFX_FaceCache::LookUpGlyphBitMap should remember its unsuccessful glyph
bitmap calculations. This is especially important if there are a lot of
repeated requests for the same glyph with large bitmaps (which means
long calculations in freetype). With this CL, the pdf in the bug below
will be rendered quickly.

BUG=chromium:638856
Committed: https://pdfium.googlesource.com/pdfium/+/8b1ed16144925205a34e3796b57db72dd6ee6a89

[npm, 2016-09-14 14:51:48]

Description was changed from

==========
Map in LookUpGlyphBitmap even when unsuccessful

CFX_FaceCache::LookUpGlyphBitMap should remember its unsuccessful glyph
bitmap calculations. This is especially important if there are a lot of
repeated requests for the same glyph with large bitmaps (which means
long calculations in freetype). With this CL, the pdf in the bug below
will be rendered quickly.

BUG=chromium:638856
==========

to

==========
Map in glyph bitmap in LookUpGlyphBitmap even when unsuccessful

CFX_FaceCache::LookUpGlyphBitMap should remember its unsuccessful glyph
bitmap calculations. This is especially important if there are a lot of
repeated requests for the same glyph with large bitmaps (which means
long calculations in freetype). With this CL, the pdf in the bug below
will be rendered quickly.

BUG=chromium:638856
==========

[npm, 2016-09-14 14:51:48]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org, weili@chromium.org

[npm, 2016-09-14 14:52:11]

Description was changed from

==========
Map in glyph bitmap in LookUpGlyphBitmap even when unsuccessful

CFX_FaceCache::LookUpGlyphBitMap should remember its unsuccessful glyph
bitmap calculations. This is especially important if there are a lot of
repeated requests for the same glyph with large bitmaps (which means
long calculations in freetype). With this CL, the pdf in the bug below
will be rendered quickly.

BUG=chromium:638856
==========

to

==========
Map glyph bitmap in LookUpGlyphBitmap even when unsuccessful

CFX_FaceCache::LookUpGlyphBitMap should remember its unsuccessful glyph
bitmap calculations. This is especially important if there are a lot of
repeated requests for the same glyph with large bitmaps (which means
long calculations in freetype). With this CL, the pdf in the bug below
will be rendered quickly.

BUG=chromium:638856
==========

[npm, 2016-09-14 14:52:55]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[npm, 2016-09-14 14:53:07]

PTAL

[commit-bot: I haz the power, 2016-09-14 14:53:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 15:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:05:07]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-14 15:09:54]

Curious about whether something could change during the lifteime of the document
such that a subsequent call might get a different, successful result.  Can you
confirm this doesn't happen?

Looks good otherwise.

[npm, 2016-09-14 15:50:53]

On 2016/09/14 15:09:54, Tom Sepez wrote:
> Curious about whether something could change during the lifteime of the
document
> such that a subsequent call might get a different, successful result.  Can you
> confirm this doesn't happen?
> 
> Looks good otherwise.

RenderGlyph should behave the same if given the same parameters. I noticed that
the bFontStyle is not included in FaceGlyphsKey, but this comes from
m_bFontStyle
from FXTEXT_CHARPOS, which only depends on the font. So it may be good to just
remove all these bFontStyles in another CL. But yes, RenderGlyph calls should
return the same if the pFont, FaceGlyphsKey, and glyph_index are the same.

[Tom Sepez, 2016-09-14 16:00:26]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-09-14 16:00:26]

lgtm

[commit-bot: I haz the power, 2016-09-14 16:00:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:00:53]

Description was changed from

==========
Map glyph bitmap in LookUpGlyphBitmap even when unsuccessful

CFX_FaceCache::LookUpGlyphBitMap should remember its unsuccessful glyph
bitmap calculations. This is especially important if there are a lot of
repeated requests for the same glyph with large bitmaps (which means
long calculations in freetype). With this CL, the pdf in the bug below
will be rendered quickly.

BUG=chromium:638856
==========

to

==========
Map glyph bitmap in LookUpGlyphBitmap even when unsuccessful

CFX_FaceCache::LookUpGlyphBitMap should remember its unsuccessful glyph
bitmap calculations. This is especially important if there are a lot of
repeated requests for the same glyph with large bitmaps (which means
long calculations in freetype). With this CL, the pdf in the bug below
will be rendered quickly.

BUG=chromium:638856

Committed:
https://pdfium.googlesource.com/pdfium/+/8b1ed16144925205a34e3796b57db72dd6ee...
==========

[commit-bot: I haz the power, 2016-09-14 16:00:54]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8b1ed16144925205a34e3796b57db72dd6ee...