Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2338883003: Add a tool for viewing instrumentation logs (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2136 lines, -0 lines) Patch
A pkg/analysis_server/tool/instrumentation/log/log.dart View 1 chunk +807 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/instrumentation/log_viewer.dart View 1 chunk +128 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/instrumentation/page/log_page.dart View 1 chunk +262 lines, -0 lines 2 comments Download
A pkg/analysis_server/tool/instrumentation/page/page_writer.dart View 1 chunk +307 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/instrumentation/page/stats_page.dart View 1 chunk +230 lines, -0 lines 2 comments Download
A pkg/analysis_server/tool/instrumentation/page/task_page.dart View 1 chunk +166 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/instrumentation/server.dart View 1 chunk +236 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
It's fairly primitive at this point, but I think it's a good place to start ...
4 years, 3 months ago (2016-09-14 14:59:24 UTC) #2
scheglov
LGTM Looks like a very useful tool! https://codereview.chromium.org/2338883003/diff/1/pkg/analysis_server/tool/instrumentation/page/log_page.dart File pkg/analysis_server/tool/instrumentation/page/log_page.dart (right): https://codereview.chromium.org/2338883003/diff/1/pkg/analysis_server/tool/instrumentation/page/log_page.dart#newcode67 pkg/analysis_server/tool/instrumentation/page/log_page.dart:67: sink.writeln('var highlightedRows ...
4 years, 3 months ago (2016-09-14 16:17:17 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2338883003/diff/1/pkg/analysis_server/tool/instrumentation/page/log_page.dart File pkg/analysis_server/tool/instrumentation/page/log_page.dart (right): https://codereview.chromium.org/2338883003/diff/1/pkg/analysis_server/tool/instrumentation/page/log_page.dart#newcode67 pkg/analysis_server/tool/instrumentation/page/log_page.dart:67: sink.writeln('var highlightedRows = [];'); Done, here and elsewhere. https://codereview.chromium.org/2338883003/diff/1/pkg/analysis_server/tool/instrumentation/page/stats_page.dart ...
4 years, 3 months ago (2016-09-14 16:39:27 UTC) #4
Brian Wilkerson
4 years, 3 months ago (2016-09-14 16:50:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37d213e60858b1bc6a97781e087498bd10c1bd46 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698