Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2338883002: Update uses of deprecated API in ddc (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -15 lines) Patch
A pkg/analyzer/lib/source/custom_resolver.dart View 1 chunk +33 lines, -0 lines 4 comments Download
M pkg/dev_compiler/lib/src/analyzer/context.dart View 3 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-13 18:23:03 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2338883002/diff/1/pkg/analyzer/lib/source/custom_resolver.dart File pkg/analyzer/lib/source/custom_resolver.dart (right): https://codereview.chromium.org/2338883002/diff/1/pkg/analyzer/lib/source/custom_resolver.dart#newcode11 pkg/analyzer/lib/source/custom_resolver.dart:11: * A resolver that maps individual URI's to ...
4 years, 3 months ago (2016-09-13 18:27:24 UTC) #3
Jennifer Messerly
lgtm, thank you!
4 years, 3 months ago (2016-09-13 18:38:18 UTC) #4
Brian Wilkerson
Committed patchset #1 (id:1) manually as 1f10422fd5cceb2004da85a15c6cd708b8fe0863 (presubmit successful).
4 years, 3 months ago (2016-09-13 18:44:43 UTC) #6
Brian Wilkerson
4 years, 3 months ago (2016-09-13 20:37:20 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2338883002/diff/1/pkg/analyzer/lib/source/cus...
File pkg/analyzer/lib/source/custom_resolver.dart (right):

https://codereview.chromium.org/2338883002/diff/1/pkg/analyzer/lib/source/cus...
pkg/analyzer/lib/source/custom_resolver.dart:11: * A resolver that maps
individual URI's to other URI's.
The original class had no comment, and I don't actually understand the purpose
of the class, so I've removed the comment.

https://codereview.chromium.org/2338883002/diff/1/pkg/analyzer/lib/source/cus...
pkg/analyzer/lib/source/custom_resolver.dart:30: .getFile(fileUri.toFilePath())
Done

Powered by Google App Engine
This is Rietveld 408576698