Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2338823002: Fix small glitches in bot-page and task-list (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fix small glitches in bot-page and task-list bot-page event list was showing the wrong version task-list wasn't prompting before cancelling a task Adds aliases for Galaxy S7 and Nexus 6p BUG=631047 Committed: https://github.com/luci/luci-py/commit/10a16b96086ea087a96d2726eada271b82cc6602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/build/js/js.js View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-list.html View 6 chunks +35 lines, -8 lines 0 comments Download
M appengine/swarming/elements/res/js/alias.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjlubick
4 years, 3 months ago (2016-09-13 13:57:56 UTC) #2
stephana-chromium
On 2016/09/13 13:57:56, kjlubick wrote: LGTM
4 years, 3 months ago (2016-09-13 14:06:18 UTC) #3
KevinL
lgtm
4 years, 3 months ago (2016-09-13 14:54:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338823002/1
4 years, 3 months ago (2016-09-13 14:55:17 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 14:58:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/10a16b96086ea087a96d2726eada271b82cc6602

Powered by Google App Engine
This is Rietveld 408576698