Issue 2338803004: arc: Make notifications from Android read by ChromeVox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2338803004: arc: Make notifications from Android read by ChromeVox. (Closed)

Created:
4 years, 3 months ago by Shuhei Takahashi

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

arc: Make notifications from Android read by ChromeVox. BUG=644154 TEST=Go through notification list in message center with ChromeVox, then ChromeVox read ARC custom notifications Review-Url: https://codereview.chromium.org/2318463002 Cr-Commit-Position: refs/heads/master@{#417202} (cherry picked from commit 02f8ca650a8976e67ec89f0a9c87da70fc34ea2e) Committed: https://chromium.googlesource.com/chromium/src/+/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -24 lines)			Patch
M	components/arc/common/notifications.mojom	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	ui/arc/notification/arc_custom_notification_item.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/message_center/notification.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/message_center/notification.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/message_center/views/message_view.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/message_center/views/message_view.cc	View	4 chunks	+25 lines, -0 lines	0 comments	Download
M	ui/message_center/views/notification_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/message_center/views/notification_view.cc	View	4 chunks	+0 lines, -17 lines	0 comments	Download

Total messages: 2 (1 generated)

Shuhei Takahashi

4 years, 3 months ago (2016-09-14 05:14:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6.