third_party/WebKit/Source/web/LinkHighlightImpl.cpp - Issue 2338803003: Blink Compositor Animation: CompositorPlayer::addAnimation to use unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

Issue 2338803003: Blink Compositor Animation: CompositorPlayer::addAnimation to use unique_ptr. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

diff --git a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

index fa8f552d23ef4e83409f8a93ef5f2c8b96491634..5d3ba12d84459a5935fd11726097502091ba7657 100644

--- a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

+++ b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

@@ -324,7 +324,7 @@ void LinkHighlightImpl::startHighlightAnimationIfNeeded()

std::unique_ptr<CompositorAnimation> animation = CompositorAnimation::create(*curve, CompositorTargetProperty::OPACITY, 0, 0);

m_contentLayer->layer()->setDrawsContent(true);

- m_compositorPlayer->addAnimation(animation.release());

+ m_compositorPlayer->addAnimation(std::move(animation));

invalidate();

m_owningWebViewImpl->mainFrameImpl()->frameWidget()->scheduleAnimation();

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | no next file » | no next file with comments »