Fix a race condition in simulator that happens when flushing icache.

Fix a race condition in simulator that happens when flushing icache.

During GC multiple threads can request icache flush when evacuating
code space in parallel.

Simulator::FlushICache updates Isolate::simulator_icache hashmap,
which leads to a race.

This patch adds a lock for simulator_icache.

BUG=

Committed: https://crrev.com/2b1753ac943735faadb683b8156348e5fac613ab
Cr-Commit-Position: refs/heads/master@{#39386}

[ulan, 2016-09-13 13:23:52]

ulan@chromium.org changed reviewers:
+ machenbach@chromium.org

[ulan, 2016-09-13 13:23:53]

ptal

[Michael Achenbach, 2016-09-13 13:40:56]

lgtm (rubber-stamp)

https://codereview.chromium.org/2338793002/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2338793002/diff/1/src/isolate.h#newcode1445
src/isolate.h:1445: abort_on_uncaught_exception_callback_;
nit: Maybe add an empty line?

[ulan, 2016-09-13 13:43:28]

Description was changed from

==========
Fix a race condition in simulator that happens when flushing icache.

During GC multiple threads can request icache flush when evacuating
code space in parallel.

Simulator::FlushICache updates Isolate::simulator_icache hashmap,
which leads to a race.

This patch add a lock for simulator_icache.

BUG=
==========

to

==========
Fix a race condition in simulator that happens when flushing icache.

During GC multiple threads can request icache flush when evacuating
code space in parallel.

Simulator::FlushICache updates Isolate::simulator_icache hashmap,
which leads to a race.

This patch adds a lock for simulator_icache.

BUG=
==========

[ulan, 2016-09-13 13:43:50]

https://codereview.chromium.org/2338793002/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2338793002/diff/1/src/isolate.h#newcode1445
src/isolate.h:1445: abort_on_uncaught_exception_callback_;
On 2016/09/13 13:40:56, machenbach (slow) wrote:
> nit: Maybe add an empty line?

Done.

[ulan, 2016-09-13 13:43:53]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-13 13:43:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2338793002/#ps20001
(title: "add new line")

[commit-bot: I haz the power, 2016-09-13 13:44:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 14:11:50]

Description was changed from

==========
Fix a race condition in simulator that happens when flushing icache.

During GC multiple threads can request icache flush when evacuating
code space in parallel.

Simulator::FlushICache updates Isolate::simulator_icache hashmap,
which leads to a race.

This patch adds a lock for simulator_icache.

BUG=
==========

to

==========
Fix a race condition in simulator that happens when flushing icache.

During GC multiple threads can request icache flush when evacuating
code space in parallel.

Simulator::FlushICache updates Isolate::simulator_icache hashmap,
which leads to a race.

This patch adds a lock for simulator_icache.

BUG=
==========

[commit-bot: I haz the power, 2016-09-13 14:11:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 14:12:22]

Description was changed from

==========
Fix a race condition in simulator that happens when flushing icache.

During GC multiple threads can request icache flush when evacuating
code space in parallel.

Simulator::FlushICache updates Isolate::simulator_icache hashmap,
which leads to a race.

This patch adds a lock for simulator_icache.

BUG=
==========

to

==========
Fix a race condition in simulator that happens when flushing icache.

During GC multiple threads can request icache flush when evacuating
code space in parallel.

Simulator::FlushICache updates Isolate::simulator_icache hashmap,
which leads to a race.

This patch adds a lock for simulator_icache.

BUG=

Committed: https://crrev.com/2b1753ac943735faadb683b8156348e5fac613ab
Cr-Commit-Position: refs/heads/master@{#39386}
==========

[commit-bot: I haz the power, 2016-09-13 14:12:23]

Patchset 2 (id:??) landed as
https://crrev.com/2b1753ac943735faadb683b8156348e5fac613ab
Cr-Commit-Position: refs/heads/master@{#39386}