Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2338763002: Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will… (Closed)

Created:
4 years, 3 months ago by yamaguchi
Modified:
4 years, 3 months ago
Reviewers:
satorux1, satorux
CC:
chromium-reviews, oshima+watch_chromium.org, fukino
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: memory leak detected in unittest Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -403 lines) Patch
M chromeos/disks/disk_mount_manager_unittest.cc View 18 chunks +222 lines, -403 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
yamaguchi
Created Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit…
4 years, 3 months ago (2016-09-13 10:30:47 UTC) #2
yamaguchi
4 years, 3 months ago (2016-09-13 11:46:23 UTC) #6
Patch 2340433002 has already been applied for reverting the same change.
https://codereview.chromium.org/2340433002/
I will close this.

Powered by Google App Engine
This is Rietveld 408576698