DevTools: Make eslint mandatory and check node.js/npm modules in presubmit

third_party/WebKit/Source/devtools/PRESUBMIT.py

Index: third_party/WebKit/Source/devtools/PRESUBMIT.py
diff --git a/third_party/WebKit/Source/devtools/PRESUBMIT.py b/third_party/WebKit/Source/devtools/PRESUBMIT.py
index 48c11e130a01d50d1cee2a88b2f54556c5aaf8a3..d135a99f9286b1ff8ad9572572d7c6b054d40d7b 100644
--- a/third_party/WebKit/Source/devtools/PRESUBMIT.py
+++ b/third_party/WebKit/Source/devtools/PRESUBMIT.py
@@ -37,6 +37,18 @@ import sys
 compile_note = "Be sure to run your patch by the compile_frontend.py script prior to committing!"
 
 
+def _CheckNodeAndNPMModules(input_api, output_api):

[lushnikov, 2016/10/05 16:22:49]

do we really need this presubmit check?

looks like all the necessary job of installing nodes/npm will be done by the
lint_javascript.py - if needed

[chenwilliam, 2016/10/05 17:59:19]

This is necessary to run "npm install", which is how eslint gets installed. We
could do the npm install step in the lint script, but as we add more build steps
using npm modules, it's better to do this as an explicit first step in the
presubmit script.

[lushnikov, 2016/10/07 17:05:43]

Shell we pursue the hermetic build for the github workflow?

[chenwilliam, 2016/10/10 19:36:17]

I'm currently going through the compliance review for the npm modules repo
(which would be used for buildbots) so for now we can't do a hermetic build
using a git checkout of the npm modules. If we're concerned about versioning, we
can shrinkwrap our package.json which locks down the versions of the entire
dependency tree.  For now, I think because it's just eslint we should be OK.

+    node_script_path = input_api.os_path.join(input_api.PresubmitLocalPath(), "scripts", "install_node_deps.py")
+    process = input_api.subprocess.Popen(
+        [input_api.python_executable, node_script_path],
+        stdout=input_api.subprocess.PIPE,
+        stderr=input_api.subprocess.STDOUT)
+    out, _ = process.communicate()
+    if process.returncode != 0:
+        return [output_api.PresubmitError(out)]
+    return [output_api.PresubmitNotifyResult(out)]
+
+
 def _CheckDevtoolsStyle(input_api, output_api):
     local_paths = [f.AbsoluteLocalPath() for f in input_api.AffectedFiles() if f.Action() != "D"]
 
@@ -54,8 +66,7 @@ def _CheckDevtoolsStyle(input_api, output_api):
         out, _ = process.communicate()
         if process.returncode != 0:
             return [output_api.PresubmitError(out)]
-        if "NOTE" in out:
-            return [output_api.PresubmitNotifyResult(out)]
+        return [output_api.PresubmitNotifyResult(out)]
     return []
 
 
@@ -153,6 +164,7 @@ def _CheckCSSViolations(input_api, output_api):
 
 def CheckChangeOnUpload(input_api, output_api):
     results = []
+    results.extend(_CheckNodeAndNPMModules(input_api, output_api))
     results.extend(_CheckDevtoolsStyle(input_api, output_api))
     results.extend(_CompileDevtoolsFrontend(input_api, output_api))
     results.extend(_CheckConvertSVGToPNGHashes(input_api, output_api))