DevTools: Make eslint mandatory and check node.js/npm modules in presubmit

third_party/WebKit/Source/devtools/scripts/local_node/node.py

 #!/usr/bin/env python
 # Copyright (c) 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import shutil
 import sys
 import subprocess
 import tarfile
 import tempfile
 import urllib2
 
 THIS_DIR = os.path.dirname(os.path.abspath(__file__))
 
-DEFAULT_VERSION = '4.5.0'
+if len(sys.argv) < 2:
+    print('Usage: {} <version>'.format(sys.argv[0]))

[lushnikov, 2016/10/12 22:10:19]

you already have a way to pass Node version in via the ENV - no need to add
another one.

[chenwilliam, 2016/10/17 19:32:27]

Done.

+    print(' <version> Specific node.js version (e.g. 4.5.0)')
+    sys.exit(1)
+
+DEFAULT_VERSION = sys.argv[1]
 BUCKET = 'chromium-nodejs'
 
 
 def install_latest_node_js(version, tmp_dir):
     target_dir = os.path.join(THIS_DIR, 'runtimes', version)
     version_file = os.path.join(target_dir, 'VERSION')
 
     if sys.platform == 'win32':
         bin_location = os.path.join(target_dir, 'node.exe')
     else:
         bin_location = os.path.join(target_dir, 'bin', 'node')
 
     # We assume that, if the VERSION file exists, then the installation is good.
     if os.path.exists(version_file):
         with open(version_file, 'r') as f:
             if f.read() == version:
                 return bin_location
 
     # TODO(hinoka): This probably doesn't work that well on Windows...
     shutil.rmtree(target_dir, ignore_errors=True)
 
     # Get the target name correct.
     if sys.platform == 'win32':
         target = 'node.exe'
     elif sys.platform == 'darwin':
-        target = 'node-v%s-darwin-x86.tar.gz' % version
+        target = 'node-v%s-darwin-x64.tar.gz' % version
     elif sys.platform == 'linux2':
         target = 'node-v%s-linux-x86.tar.gz' % version
     else:
         raise Exception('Unrecognized platform %s' % sys.platform)
 
     dest = os.path.join(tmp_dir, 'node_download')
     url = 'https://storage.googleapis.com/%s/%s/%s' % (
         BUCKET, version, target)
     print('Fetching %s' % url)
     u = urllib2.urlopen(url)
@@ skipping 52 matching lines @@
         tmp_dir = tempfile.mkdtemp(dir=THIS_DIR)
         bin_location = install_latest_node_js(version, tmp_dir)
     finally:
         if os.path.exists(tmp_dir):
             shutil.rmtree(tmp_dir)
 
     if mode == 'npm':
         # TODO(hinoka): How about Windows...?
         bin_location = os.path.join(os.path.dirname(bin_location), 'npm')
 
-    return subprocess.call([bin_location, ] + sys.argv[1:])
+    return subprocess.call([bin_location, ] + sys.argv[2:])
 
 
 if __name__ == '__main__':
     sys.exit(main())