Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/history/core/browser/history_backend.cc

Issue 2338703003: [NTP] Fix article suggestion clicks contributing to Most Visited tiles (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | components/sessions/core/serialized_navigation_entry.cc » ('j') | ui/base/page_transition_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_backend.cc
diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc
index ff46dd8c34b1032a78050d742cfe70eacf79389e..d9f7e392d4fc3f43d7827c1475e25728f7d52560 100644
--- a/components/history/core/browser/history_backend.cc
+++ b/components/history/core/browser/history_backend.cc
@@ -355,7 +355,9 @@ SegmentID HistoryBackend::UpdateSegments(const GURL& url,
ui::PAGE_TRANSITION_TYPED) ||
ui::PageTransitionCoreTypeIs(transition_type,
ui::PAGE_TRANSITION_AUTO_BOOKMARK)) &&
- (transition_type & ui::PAGE_TRANSITION_FORWARD_BACK) == 0) {
+ (transition_type & ui::PAGE_TRANSITION_FORWARD_BACK) == 0 &&
+ (transition_type & ui::PAGE_TRANSITION_IGNORE_FOR_NTP_MOST_VISITED) ==
+ 0) {
// If so, create or get the segment.
std::string segment_name = db_->ComputeSegmentName(url);
URLID url_id = db_->GetRowForURL(url, nullptr);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | components/sessions/core/serialized_navigation_entry.cc » ('j') | ui/base/page_transition_types.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698