[NTP] Fix article suggestion clicks contributing to Most Visited tiles

components/history/core/browser/history_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/history_backend.h"
 
 #include <algorithm>
 #include <functional>
 #include <list>
 #include <map>
@@ skipping 337 matching lines @@
   // navigation is for the entry google.com transition typed. We end up adding
   // a segment for that one as well. So we end up with google.net and google.com
   // in the segment table, showing as 2 entries in the NTP.
   // Note also that we should still be updating the visit count for that segment
   // which we are not doing now. It should be addressed when
   // http://crbug.com/96860 is fixed.
   if ((ui::PageTransitionCoreTypeIs(transition_type,
                                     ui::PAGE_TRANSITION_TYPED) ||
        ui::PageTransitionCoreTypeIs(transition_type,
                                     ui::PAGE_TRANSITION_AUTO_BOOKMARK)) &&
-      (transition_type & ui::PAGE_TRANSITION_FORWARD_BACK) == 0) {
+      (transition_type & ui::PAGE_TRANSITION_FORWARD_BACK) == 0 &&
+      (transition_type & ui::PAGE_TRANSITION_IGNORE_FOR_NTP_TILES) == 0) {

[sky, 2016/09/13 19:12:23]

Please add coverage of this to history related unittests.

[mastiz1, 2016/09/13 20:52:16]

Done.

     // If so, create or get the segment.
     std::string segment_name = db_->ComputeSegmentName(url);
     URLID url_id = db_->GetRowForURL(url, nullptr);
     if (!url_id)
       return 0;
 
     segment_id = db_->GetSegmentNamed(segment_name);
     if (!segment_id) {
       segment_id = db_->CreateSegment(url_id, segment_name);
       if (!segment_id) {
@@ skipping 2299 matching lines @@
   // transaction is currently open.
   db_->CommitTransaction();
   db_->Vacuum();
   db_->BeginTransaction();
   db_->GetStartDate(&first_recorded_time_);
 
   return true;
 }
 
 }  // namespace history