[NTP] Fix article suggestion clicks contributing to Most Visited tiles

components/sessions/core/serialized_navigation_entry_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sessions/core/serialized_navigation_entry.h"
 
 #include <stdint.h>
 
 #include <cstddef>
 #include <memory>
@@ skipping 149 matching lines @@
   EXPECT_EQ(test_data::kFaviconURL.spec(), sync_data.favicon_url());
   EXPECT_EQ(test_data::kHttpStatusCode, sync_data.http_status_code());
   // The proto navigation redirects don't include the final chain entry
   // (because it didn't redirect) so the lengths should differ by 1.
   ASSERT_EQ(3, sync_data.navigation_redirect_size() + 1);
   EXPECT_EQ(test_data::kRedirectURL0.spec(),
             sync_data.navigation_redirect(0).url());
   EXPECT_EQ(test_data::kRedirectURL1.spec(),
             sync_data.navigation_redirect(1).url());
   EXPECT_FALSE(sync_data.has_last_navigation_redirect_url());
+  EXPECT_FALSE(sync_data.has_navigation_ignore_for_ntp_tiles());
 }
 
 // Test that the last_navigation_redirect_url is set when needed.  This test is
 // just like the above, but with a different virtual_url.  Create a
 // SerializedNavigationEntry, then create a sync protocol buffer from it.  The
 // protocol buffer should have a last_navigation_redirect_url.
 TEST(SerializedNavigationEntryTest, LastNavigationRedirectUrl) {
   SerializedNavigationEntry navigation =
       SerializedNavigationEntryTestHelper::CreateNavigationForTest();
   SerializedNavigationEntryTestHelper::SetVirtualURL(
@@ skipping 38 matching lines @@
           SerializedNavigationEntry::FromSyncData(test_data::kIndex, sync_data);
       const ui::PageTransition constructed_transition =
           constructed_nav.transition_type();
 
       EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
           constructed_transition, transition));
     }
   }
 }
 
+TEST(SerializedNavigationEntryTest, IgnoreForNtpTiles) {

[Bernhard Bauer, 2016/09/13 15:17:38]

Probably for a followup, but what would be more interesting than this would be
an instrumentation test that opens a snippet and verifies that the flag is set.

+  SerializedNavigationEntry navigation =
+      SerializedNavigationEntryTestHelper::CreateNavigationForTest();
+  SerializedNavigationEntryTestHelper::SetTransitionType(
+      ui::PageTransitionFromInt(ui::PAGE_TRANSITION_AUTO_BOOKMARK |
+                                ui::PAGE_TRANSITION_IGNORE_FOR_NTP_TILES),
+      &navigation);
+  const sync_pb::TabNavigation sync_data = navigation.ToSyncData();
+  EXPECT_TRUE(sync_data.navigation_ignore_for_ntp_tiles());
+}
+
 }  // namespace
 }  // namespace sessions