Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2338623005: Add check for trivial string equality (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add check for trivial string equality BUG= Committed: https://pdfium.googlesource.com/pdfium/+/3d704888eb6f5c72edd3abe6e5e48a62ef218975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M core/fxcrt/fx_basic_bstring.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M core/fxcrt/fx_basic_wstring.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Its likely that two strings may be sharing the same underlying buffer, in which case ...
4 years, 3 months ago (2016-09-13 23:39:26 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-14 01:08:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338623005/1
4 years, 3 months ago (2016-09-14 01:08:50 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 01:10:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3d704888eb6f5c72edd3abe6e5e48a62ef21...

Powered by Google App Engine
This is Rietveld 408576698