third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-effectively-2g.html - Issue 2338623004: Add Blink setting to block doc.written scripts on 2g-like networks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-effectively-2g.html

Issue 2338623004: Add Blink setting to block doc.written scripts on 2g-like networks (Closed)

Patch Set: Nit Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-effectively-2g-expected.txt » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script>	4 <script>

5 var src = 'http://localhost:8000/loading/resources/js-loaded.js?conn-type';	5 var src = 'http://localhost:8000/loading/resources/js-loaded.js?conn-type';

6 var jsLoaded = false;	6 var jsLoaded = false;

7 var loadSuccess = false;	7 var loadSuccess = false;

8 if (window.internals) {	8 if (window.internals) {

9 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOnSlow Connections(true);	9 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameIfEffe ctively2G(true);

10 internals.setNetworkConnectionInfoOverride(true, 'cellular3g', 2.0);	10 internals.setNetworkConnectionInfoOverride(true, 'cellular3g', 2.0);

	11 internals.setEffectiveConnectionTypeOverride('TypeSlow2G');

11 internals.evictAllResources();	12 internals.evictAllResources();

12	13

13 window.addEventListener('beforeunload', function() {	14 window.addEventListener('beforeunload', function() {

14 internals.clearNetworkConnectionInfoOverride();	15 internals.clearNetworkConnectionInfoOverride();

15 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOn SlowConnections(false);	16 internals.clearEffectiveConnectionTypeOverride();

	17 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameIf Effectively2G(false);

16 }, false);	18 }, false);

17 }	19 }

18 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');	20 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');

19 </script>	21 </script>

20 <script>	22 <script>

21 test(function () {	23 test(function () {

22 assert_true(jsLoaded);	24 assert_false(jsLoaded);

23 assert_true(loadSuccess);	25 assert_false(loadSuccess);

24 }, "Document.written scripts are not blocked in a fast connection");	26 }, "Document.written scripts are blocked when effectively 2G");

25 </script>	27 </script>

OLD	NEW