Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: tracing/tracing/model/clock_sync_manager.html

Issue 2338583002: Make clock sync latency metric go between each pair of clock domains. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/clock_sync_manager.html
diff --git a/tracing/tracing/model/clock_sync_manager.html b/tracing/tracing/model/clock_sync_manager.html
index 82531ce46a3b8b41ea444bfaba3890340f22ef74..4aaa0e9a813a02b0298f5ca78a84f6afa3862015 100644
--- a/tracing/tracing/model/clock_sync_manager.html
+++ b/tracing/tracing/model/clock_sync_manager.html
@@ -148,29 +148,31 @@ tr.exportTo('tr.model', function() {
* the first alphabetically is selected.
*/
getModelTimeTransformer: function(domainId) {
- return this.getModelTimeTransformerRaw_(domainId).fn;
+ this.onDomainSeen_(domainId);
+
+ if (!this.modelDomainId_)
+ this.selectModelDomainId_();
+
+ return this.getTimeTransformerRaw_(domainId, this.modelDomainId_).fn;
},
/**
* Returns the error associated with the transformation given by
* |getModelTimeTransformer(domainId)|.
*/
- getModelTimeTransformerError: function(domainId) {
- return this.getModelTimeTransformerRaw_(domainId).error;
+ getTimeTransformerError: function(fromDomainId, toDomainId) {
+ this.onDomainSeen_(fromDomainId);
+ this.onDomainSeen_(toDomainId);
+ return this.getTimeTransformerRaw_(fromDomainId, toDomainId).error;
},
- getModelTimeTransformerRaw_: function(domainId) {
- this.onDomainSeen_(domainId);
-
- if (!this.modelDomainId_)
- this.selectModelDomainId_();
-
+ getTimeTransformerRaw_: function(fromDomainId, toDomainId) {
var transformer =
- this.getTransformerBetween_(domainId, this.modelDomainId_);
+ this.getTransformerBetween_(fromDomainId, toDomainId);
if (!transformer) {
throw new Error('No clock sync markers exist pairing clock domain "' +
- domainId + '" ' + 'with model clock domain "' +
- this.modelDomainId_ + '".');
+ fromDomainId + '" ' + 'with target clock domain "' +
+ toDomainId + '".');
}
return transformer;

Powered by Google App Engine
This is Rietveld 408576698